Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacymarket audit fixes #2133

Merged
merged 50 commits into from
Mar 5, 2024
Merged

Legacymarket audit fixes #2133

merged 50 commits into from
Mar 5, 2024

Commits on Jun 29, 2023

  1. fixes from audit 

    * fix critical `migrateOnBehalf` is broken because snx token does not approve the transfer. approval shuoldn't be necessary
* prevent escrow entries from being created by untrusted entities. otherwise escrow entries would be vulnerabile to a type of smashing attack
    @dbeal-eth
    dbeal-eth committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    a60a474 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. fix msg sender should be target on migrate func

    @dbeal-eth
    dbeal-eth committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    c961a2a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Merge branch 'develop' into legacymarket-audit-fixes

    @barrasso
    barrasso authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    a5a9183 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge remote-tracking branch 'origin/develop' into legacymarket-audit… 

    …-fixes
    @dbeal-eth
    dbeal-eth committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    fcf3d6f View commit details
    Browse the repository at this point in the history

  2. feedback

    @dbeal-eth
    dbeal-eth committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e35affe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'legacymarket-audit-fixes' of https://github.com/Synthet… 

    …ixio/synthetix into legacymarket-audit-fixes
    @dbeal-eth
    dbeal-eth committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6ea1fbb View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge branch 'develop' into legacymarket-audit-fixes

    @barrasso
    barrasso authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f479a9a View commit details
    Browse the repository at this point in the history

  2. fix lint

    @barrasso
    barrasso committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3f1d2a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. fix tests

    @barrasso
    barrasso committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    877bf10 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into legacymarket-audit-fixes

    @barrasso
    barrasso committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    209fd0b View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Fix Liquidator unit tests

    @barrasso
    barrasso committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    40b9925 View commit details
    Browse the repository at this point in the history

  2. fix unit tests

    @barrasso
    barrasso committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    96da286 View commit details
    Browse the repository at this point in the history

  3. fix fork tests

    @barrasso
    barrasso committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    299e31f View commit details
    Browse the repository at this point in the history

  4. fix int dual tests

    @barrasso
    barrasso committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    5775edc View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. fix fork

    @barrasso
    barrasso committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    51dcca5 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. update optimism commit hash for ops tool

    @barrasso
    barrasso committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    943b9ad View commit details
    Browse the repository at this point in the history

  2. update op commit hash

    @barrasso
    barrasso committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7021b1d View commit details
    Browse the repository at this point in the history

  3. add node 18.17.1 op commit hash

    @barrasso
    barrasso committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    308cb43 View commit details
    Browse the repository at this point in the history

  4. update commit hash

    @barrasso
    barrasso committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2c6f319 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. update configure reward escrow script and op commit hash

    @barrasso
    barrasso committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f1faa31 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Update docker-node image

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b9766e1 View commit details
    Browse the repository at this point in the history

  2. revert package-lock.json

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    214db6e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into legacymarket-audit-fixes

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    22ec001 View commit details
    Browse the repository at this point in the history

  4. revert op commit change

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9e2a856 View commit details
    Browse the repository at this point in the history

  5. run npm i

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5e21373 View commit details
    Browse the repository at this point in the history

  6. Update job-header-machine.yml machine image tag

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d1be527 View commit details
    Browse the repository at this point in the history

  7. install node version 18.19

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d196e9b View commit details
    Browse the repository at this point in the history

  8. fix config

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    81c9564 View commit details
    Browse the repository at this point in the history

  9. fix config 2

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7e1d521 View commit details
    Browse the repository at this point in the history

  10. fix ci lint

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1c2e386 View commit details
    Browse the repository at this point in the history

  11. use op commit hash when upgraded to node 18

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5d78548 View commit details
    Browse the repository at this point in the history

  12. use op commit hash after upgraded to node 18

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1d14c88 View commit details
    Browse the repository at this point in the history

  13. Add install pnpm step

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4a87b3f View commit details
    Browse the repository at this point in the history

  14. update pnpm options

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e25e97e View commit details
    Browse the repository at this point in the history

  15. add install cmd

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0b29e20 View commit details
    Browse the repository at this point in the history

  16. remove sh -c

    @barrasso
    barrasso committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    53c382d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Use commandSync

    @barrasso
    barrasso committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    60366f0 View commit details
    Browse the repository at this point in the history

  2. revert to sync

    @barrasso
    barrasso committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ee01bfa View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. update pnpm commands

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    26521cd View commit details
    Browse the repository at this point in the history

  2. update ci image tag and revert task-ops

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1fec5df View commit details
    Browse the repository at this point in the history

  3. use optimism v1.7.0 tag

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2783827 View commit details
    Browse the repository at this point in the history

  4. pull docker node instead of building

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b61eb0a View commit details
    Browse the repository at this point in the history

  5. remove gcloud command

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e73ab96 View commit details
    Browse the repository at this point in the history

  6. update _start func and remove build step from ci

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    54b27ff View commit details
    Browse the repository at this point in the history

  7. port mapping

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    79b0ed3 View commit details
    Browse the repository at this point in the history

  8. Update ops task and circleci config

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a439588 View commit details
    Browse the repository at this point in the history

  9. log node version

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b7d33d4 View commit details
    Browse the repository at this point in the history

  10. update task-ops.js

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    87be523 View commit details
    Browse the repository at this point in the history

  11. revert stuff

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    91b1962 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'develop' into legacymarket-audit-fixes

    @barrasso
    barrasso committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4e144eb View commit details
    Browse the repository at this point in the history