Legacymarket audit fixes #2133
Merged
Legacymarket audit fixes #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix critical `migrateOnBehalf` is broken because snx token does not approve the transfer. approval shuoldn't be necessary * prevent escrow entries from being created by untrusted entities. otherwise escrow entries would be vulnerabile to a type of smashing attack
barrasso
requested changes
Aug 14, 2023
barrasso
approved these changes
Aug 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2133 +/- ##
===========================================
- Coverage 92.48% 92.48% -0.01%
===========================================
Files 91 91
Lines 2276 2274 -2
Branches 673 672 -1
===========================================
- Hits 2105 2103 -2
Misses 171 171 ☔ View full report in Codecov by Sentry. |
barrasso
force-pushed
the
legacymarket-audit-fixes
branch
from
5b2c8ae
to
ee01bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some required fixes as part of the audit for the legacy market on the v3 side.