Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop symlink #56

Merged
merged 1 commit into from
Jul 12, 2024
Merged

drop symlink #56

merged 1 commit into from
Jul 12, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Jul 11, 2024

Unsure if this is clearer or not. Feel free to close without merging and/or improve it.

@casperdcl casperdcl self-assigned this Jul 11, 2024
@casperdcl casperdcl requested a review from KrisThielemans July 11, 2024 14:07
@casperdcl casperdcl added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 11, 2024
Copy link
Member Author

@casperdcl casperdcl Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an alternative, we could create a simple file here doing

from main_ISTA import Submission, submission_callbacks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could still create conflicts with their own set-up, so am happy with the current solution.

@casperdcl casperdcl mentioned this pull request Jul 11, 2024
@casperdcl casperdcl merged commit 35a6c4c into main Jul 12, 2024
2 checks passed
@casperdcl casperdcl deleted the drop-symlink branch July 12, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants