Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main_OSEM #54

Merged
merged 4 commits into from
Jul 11, 2024
Merged

main_OSEM #54

merged 4 commits into from
Jul 11, 2024

Conversation

KrisThielemans
Copy link
Member

No description provided.

@KrisThielemans KrisThielemans added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 10, 2024
@KrisThielemans KrisThielemans self-assigned this Jul 10, 2024
@KrisThielemans
Copy link
Member Author

Note that when executing this, I get

NaN or Inf found in input tensor.

whenever the metrics are computed. Presumably it's a TensorBoard message. Images are fine though, so I don't know what's causing this.

main_OSEM.py Outdated Show resolved Hide resolved
Copy link
Member

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistent naming

main_OSEM.py Outdated Show resolved Hide resolved
main_OSEM.py Outdated Show resolved Hide resolved
main_OSEM.py Outdated Show resolved Hide resolved
@casperdcl casperdcl changed the title provide example implementing OSEM main_OSEM Jul 11, 2024
main_OSEM.py Outdated Show resolved Hide resolved
main_OSEM.py Outdated Show resolved Hide resolved
@KrisThielemans
Copy link
Member Author

import check fails

  File "/opt/conda/lib/python3.10/dataclasses.py", line 812, in _get_field
    raise ValueError(f'mutable default {type(f.default)} for field '
ValueError: mutable default <class 'dict'> for field voi_masks is not allowed: use default_factory

Needs a merge with main?

Note that I see Python 3.10, while I believe somewhere we say we're using 3.11.

Otherwise, just (squash) merge.

@casperdcl casperdcl merged commit a62efb0 into main Jul 11, 2024
2 checks passed
@casperdcl casperdcl deleted the OSEM_example branch July 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants