Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-1846: Bump HTMLProofer from v3 to v4 #298

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Sep 18, 2022

  1. Configuration menu
    Copy the full SHA
    cd96ec5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. DX-1846: Stop using theme

    Remove references to `swedbank-pay-design-guide-jekyll-theme` to break
    the circular dependency between the two codebases.
    asbjornu committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    96216da View commit details
    Browse the repository at this point in the history
  2. DX-1846: Disable debug

    Disable debug to avoid HTMLProofer loading awesome_print, because it
    leads to the following failure:
    
    ```
    Traceback (most recent call last):
    	10: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `<main>'
    	 9: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `require_relative'
    	 8: from /var/jekyll/entrypoint/lib/commander.rb:7:in `<top (required)>'
    	 7: from /var/jekyll/entrypoint/lib/commander.rb:7:in `require_relative'
    	 6: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `<top (required)>'
    	 5: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `require'
    	 4: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `<top (required)>'
    	 3: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `require_relative'
    	 2: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html_proofer.rb:18:in `<top (required)>'
    	 1: from /usr/gem/ruby/2.7.0/gems/zeitwerk-2.6.0/lib/zeitwerk/kernel.rb:35:in `require'
    ```
    
    https://github.com/SwedbankPay/jekyll-plantuml-docker/actions/runs/3079379097/jobs/4975588911#step:5:2106
    asbjornu committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    a7697d8 View commit details
    Browse the repository at this point in the history
  3. DX-1846: Use %w or %W for an array of words.

    - Fix the RuboCop error:
      lib/commands/verifier.rb:78:21: C: [Corrected] Style/WordArray:
      Use %w or %W for an array of words.
    - Add rubocop-rake and rubocop-rspec to rubocop config.
    asbjornu committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    0578e66 View commit details
    Browse the repository at this point in the history
  4. DX-1846: Add reference to awesome_print

    See 60ca6c7 for an explanation.
    asbjornu committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    3831363 View commit details
    Browse the repository at this point in the history
  5. DX-1846: Fix links

    asbjornu committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    966a308 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b6ab8b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2bc2343 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    05b365a View commit details
    Browse the repository at this point in the history