-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX-1846: Bump HTMLProofer from v3 to v4 #298
Open
asbjornu
wants to merge
9
commits into
main
Choose a base branch
from
feature/dx-1846_htmlproofer_bump
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cd96ec5 - Browse repository at this point
Copy the full SHA cd96ec5View commit details
Commits on Sep 19, 2022
-
Remove references to `swedbank-pay-design-guide-jekyll-theme` to break the circular dependency between the two codebases.
Configuration menu - View commit details
-
Copy full SHA for 96216da - Browse repository at this point
Copy the full SHA 96216daView commit details -
Disable debug to avoid HTMLProofer loading awesome_print, because it leads to the following failure: ``` Traceback (most recent call last): 10: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `<main>' 9: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `require_relative' 8: from /var/jekyll/entrypoint/lib/commander.rb:7:in `<top (required)>' 7: from /var/jekyll/entrypoint/lib/commander.rb:7:in `require_relative' 6: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `<top (required)>' 5: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `require' 4: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `<top (required)>' 3: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `require_relative' 2: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html_proofer.rb:18:in `<top (required)>' 1: from /usr/gem/ruby/2.7.0/gems/zeitwerk-2.6.0/lib/zeitwerk/kernel.rb:35:in `require' ``` https://github.com/SwedbankPay/jekyll-plantuml-docker/actions/runs/3079379097/jobs/4975588911#step:5:2106
Configuration menu - View commit details
-
Copy full SHA for a7697d8 - Browse repository at this point
Copy the full SHA a7697d8View commit details -
DX-1846: Use %w or %W for an array of words.
- Fix the RuboCop error: lib/commands/verifier.rb:78:21: C: [Corrected] Style/WordArray: Use %w or %W for an array of words. - Add rubocop-rake and rubocop-rspec to rubocop config.
Configuration menu - View commit details
-
Copy full SHA for 0578e66 - Browse repository at this point
Copy the full SHA 0578e66View commit details -
DX-1846: Add reference to awesome_print
See 60ca6c7 for an explanation.
Configuration menu - View commit details
-
Copy full SHA for 3831363 - Browse repository at this point
Copy the full SHA 3831363View commit details -
Configuration menu - View commit details
-
Copy full SHA for 966a308 - Browse repository at this point
Copy the full SHA 966a308View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6ab8b3 - Browse repository at this point
Copy the full SHA b6ab8b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bc2343 - Browse repository at this point
Copy the full SHA 2bc2343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05b365a - Browse repository at this point
Copy the full SHA 05b365aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.