Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-1846: Bump HTMLProofer from v3 to v4 #298

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

asbjornu
Copy link
Contributor

DX-1846: Bump HTMLProofer from v3 to v4 and html-proofer-unrendered-markdown from v0.1 to v0.2.

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49f6922) 94.64% compared to head (05b365a) 94.64%.
Report is 224 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          28       28           
  Lines         784      784           
=======================================
  Hits          742      742           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remove references to `swedbank-pay-design-guide-jekyll-theme` to break
the circular dependency between the two codebases.
@asbjornu asbjornu force-pushed the feature/dx-1846_htmlproofer_bump branch from f934d69 to f2765d2 Compare September 19, 2022 09:40
Disable debug to avoid HTMLProofer loading awesome_print, because it
leads to the following failure:

```
Traceback (most recent call last):
	10: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `<main>'
	 9: from /var/jekyll/entrypoint/lib/entrypoint.rb:3:in `require_relative'
	 8: from /var/jekyll/entrypoint/lib/commander.rb:7:in `<top (required)>'
	 7: from /var/jekyll/entrypoint/lib/commander.rb:7:in `require_relative'
	 6: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `<top (required)>'
	 5: from /var/jekyll/entrypoint/lib/commands/verifier.rb:4:in `require'
	 4: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `<top (required)>'
	 3: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html-proofer.rb:3:in `require_relative'
	 2: from /usr/gem/ruby/2.7.0/gems/html-proofer-4.4.0/lib/html_proofer.rb:18:in `<top (required)>'
	 1: from /usr/gem/ruby/2.7.0/gems/zeitwerk-2.6.0/lib/zeitwerk/kernel.rb:35:in `require'
```

https://github.com/SwedbankPay/jekyll-plantuml-docker/actions/runs/3079379097/jobs/4975588911#step:5:2106
- Fix the RuboCop error:
  lib/commands/verifier.rb:78:21: C: [Corrected] Style/WordArray:
  Use %w or %W for an array of words.
- Add rubocop-rake and rubocop-rspec to rubocop config.
@asbjornu asbjornu force-pushed the feature/dx-1846_htmlproofer_bump branch 3 times, most recently from 54c538e to 76f5404 Compare September 19, 2022 14:21
@asbjornu asbjornu force-pushed the feature/dx-1846_htmlproofer_bump branch from 76f5404 to 966a308 Compare September 19, 2022 20:22
@asbjornu asbjornu force-pushed the feature/dx-1846_htmlproofer_bump branch 2 times, most recently from 6363097 to 09eadcc Compare September 19, 2022 21:51
@asbjornu asbjornu force-pushed the feature/dx-1846_htmlproofer_bump branch from 09eadcc to 05b365a Compare September 19, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant