Added a SlotModificationService to do shift deletion and updates in a controlled way. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvedeane
reviewed
Jun 22, 2024
…ions in SlotModificationService First tests, for now only for SlotModificationService.pick_shift_templates
|
@tvedeane I added a few tests, hopefully they help understand what's happening! |
tvedeane
reviewed
Jun 24, 2024
Co-authored-by: Marek J <[email protected]>
…dated by comparing sets instead of lists, since the order doesn't matter (test was green on my machine but red in github actions)
tvedeane
approved these changes
Jun 24, 2024
| } | ||
|
|
||
| @classmethod | ||
| def preview_changes( |
There was a problem hiding this comment.
Seems this method is not used, did you add it for future use?
There was a problem hiding this comment.
Yes I thought we may want to see if a change would affect anyone before applying the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we want to many slots now and later make slot deletion available for Vorstand members, I made a little service that searches for the most appropriate slots to update (the ones without a member registered to them if available) and prints out which members are affected by the changes so that they can be contacted if necessary.
I added a management command so that it's easy to test, edit the command then run:
docker compose exec web poetry run python manage.py test_slot_modification_serviceI'm hoping it could be used as a base or as a reference if we make slot deletion available for Vorstand members.
I'm fairly confident that it works as intended, but it'd be great to have some feedback on how readable it is. Thanks!