481 Add confirmation checkbox before giving solidarity shifts #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne Solidarity Status added, when a users balance is not negative (i.e. they cannot use a solidarity shift)
tvedeane
reviewed
Feb 14, 2024
| @@ -157,6 +174,11 @@ | |||
| {% blocktranslate with used_solidarity_shifts_current_year=used_solidarity_shifts_current_year %} | |||
| <p>There are Solidarity Shifts available for you to use. You used {{ used_solidarity_shifts_current_year }} out of 2 Solidarity Shifts this year</p> | |||
| {% endblocktranslate %} | |||
| {% elif used_solidarity_shifts_current_year < 2 and user.shift_user_data.get_available_solidarity_shifts and user.shift_user_data.get_account_balance <= 0 %} | |||
| {% blocktranslate %} | |||
| <p>You cannot receive a Solidarity Shift at the moment</p> | |||
There was a problem hiding this comment.
Would it make sense to add explanation to the user why they cannot receive it?
Plus also the translation is missing.
There was a problem hiding this comment.
I also thought about that. Maybe we could use a tooltip (https://getbootstrap.com/docs/5.3/components/tooltips/#custom-tooltips) that shows some more info when a user hovers over the text?
| <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> | ||
| </div> | ||
| <div class="modal-body"> | ||
| {% translate 'One of your banked shifts will be donated as a solidarity shift. Do you want to continue?' %} |
There was a problem hiding this comment.
Do we need a German translation of this text?
…rding solidarity shifts
tvedeane
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmation checkbox for giving solidarity shifts added. Also, one solidarity status added, when a users balance is not negative (i.e. they cannot use a solidarity shift)