Renovate/multi stage docker

[crosspolar]

Changed the Dockerfile to a multi-stage docker in order to reduce image size from 1.54GB to roughly 471 MB and eliminate Docker vulnerability errors.

Structure of the image is that .venv lies in root and the app in app. This made it easier for Pycharm to detect the venv-executable when Debugging and poetry run is not necessary anymore.

I'm not sure if all packages are installed in the final build (maybe SSL is missing?).

[crosspolar]

Also related to #424

[Theophile-Madet]

One more great suggestion! Thank you!

It's not quite ready because we can't run the tests without the dev modules installed by poetry. I tried with them installed but I got errors :

FAILED tapir/coop/tests/test_send_membership_confirmation_email.py::TestSendMembershipConfirmationEmail::test_sends_correct_mail_to_investing_member - AttributeError: function/symbol 'pango_context_set_round_glyph_positions' not found in library 'libpango-1.0.so.0': /usr/lib/x86_64-linux-gnu/libpango-1.0.so.0: undefined symbol: pango_context_set_round_glyph_positions

Could you look into them?

[Theophile-Madet]

CONTRIBUTING.md suggests restarting the container so that compilemessages runs, if we don't run compilemessages on start we should update the doc.

[crosspolar]

One more great suggestion! Thank you!

It's not quite ready because we can't run the tests without the dev modules installed by poetry. I tried with them installed but I got errors :

FAILED tapir/coop/tests/test_send_membership_confirmation_email.py::TestSendMembershipConfirmationEmail::test_sends_correct_mail_to_investing_member - AttributeError: function/symbol 'pango_context_set_round_glyph_positions' not found in library 'libpango-1.0.so.0': /usr/lib/x86_64-linux-gnu/libpango-1.0.so.0: undefined symbol: pango_context_set_round_glyph_positions

Could you look into them?

Thanks for having a good look!

We could create an extra stage with dev-dependencies and build it for testing only, e.g.

  web:
    build:
      context: .
      target: testing

Would that be possible with Github actions to override target with runtime or similar?

[Theophile-Madet]

Would that be possible with Github actions to override target with runtime or similar?

Since both GitHub actions and local development use the same docker-compose.yml file, but production uses a separate one, as long as we specify in the docker-compose file that is in this repo that we want the test stuff installed too, we should be fine?

[crosspolar]

I'll close it and retry later