Add reminder for account creation #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvedeane
force-pushed
the
account-creation-reminder
branch
from
0015691 to
1120edf
Compare
tvedeane
commented
Dec 20, 2023
tvedeane
commented
Dec 20, 2023
tapir/accounts/templates/accounts/email/create_account_reminder.body.default.html
Show resolved
Hide resolved
tvedeane
commented
Dec 20, 2023
tapir/accounts/management/commands/send_create_account_reminder.py
Outdated
Show resolved
Hide resolved
tvedeane
commented
Dec 20, 2023
tapir/accounts/templates/accounts/email/create_account_reminder.body.default.html
Show resolved
Hide resolved
tvedeane
commented
Dec 21, 2023
tvedeane
commented
Dec 21, 2023
tvedeane
force-pushed
the
account-creation-reminder
branch
from
d0cfbfe to
b514131
Compare
added 2 commits
December 21, 2023 15:49
Theophile-Madet
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
With tests and translations even, this is perfect!
Pinging @alexusfied in case you want to have a look at how we send emails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by calling
docker compose exec -w /app/tapir web poetry run python ../manage.py send_create_account_reminderand checking the generated HTML in the browser.