Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various scope adjustments to ST Terraform syntax #58

Merged
merged 11 commits into from
Aug 7, 2024
Merged

Various scope adjustments to ST Terraform syntax #58

merged 11 commits into from
Aug 7, 2024

Commits on Jul 25, 2024

  1. Remove duplicate "hcl" file extension 

    It's already in the HCL syntax definition alias.

Was likely incorrectly resolved during
1576c26 after it had been removed in
5d4c9f0.
    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0ba7c5a View commit details
    Browse the repository at this point in the history

  2. Remove capturing group

    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8f48a17 View commit details
    Browse the repository at this point in the history

  3. Use punctuation scope for accessor

    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    71ee807 View commit details
    Browse the repository at this point in the history

  4. Use keyword.declaration scope

    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    99b61e7 View commit details
    Browse the repository at this point in the history

  5. Simplify colon match

    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7d41a4f View commit details
    Browse the repository at this point in the history

  6. Adjust interpolation scopes 

    - Span `meta.string` over the entire string.
- Use `punctuation.section` for interpolation punctuation.
- Highlight `~` operator to trim whitespace only immediately next to the
  section punctuation.
- Set `source.terraform` scope for the interpolation body.
    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7f9aacb View commit details
    Browse the repository at this point in the history

  7. Use variable.language for special identifiers 

    These identifiers (called "variables" by the spec) are semantically not
constants. Instead, they provide access to external value sources and
should thus be scoped as special language variables comparable to the
C-like `this` or Python's `self`.
    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d317e36 View commit details
    Browse the repository at this point in the history

  8. A colon in a for loop is punctuation 

    Scope name was inspired by Python.
    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    65379aa View commit details
    Browse the repository at this point in the history

  9. Adjust scopes in for loops 

    `in` is a proper keyword here, not an operator.
    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    eb7103f View commit details
    Browse the repository at this point in the history

  10. A => separator in object for loops is punctuation

    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    57296e5 View commit details
    Browse the repository at this point in the history

  11. Simplify tfvars tests 

    Having basically a copy of the test file for the identical terraform
syntax is quite redundant. Instead, only test for a few excerpts of
that syntax to ensure the inclusion works as expected.
    @FichteFoll
    FichteFoll committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ad9dbf7 View commit details
    Browse the repository at this point in the history