Various scope adjustments to ST Terraform syntax #58
Conversation
FichteFoll
changed the title
|
Also, in case you're not interested in maintaining this repo anymore, we could also adopt it into the SublimeText org, where we have several people capable of merging pull requests that are also active Sublime Text users. |
|
I also noticed that some of the punctuation scope changes have actually been like this before but were reverted later in a680585 and e895f03. Since the punctuation scopes are indeed the standardized scope names and have been in use by the default packages, I don't think the arguments mentioned in the commit messages hold anymore (if they ever did). Also also, I consider the tmLanguage variants of this syntax to be deprecated since ST2 is long gone and I don't want anything to do with them anymore, personally. |
- Span `meta.string` over the entire string. - Use `punctuation.section` for interpolation punctuation. - Highlight `~` operator to trim whitespace only immediately next to the section punctuation. - Set `source.terraform` scope for the interpolation body.
These identifiers (called "variables" by the spec) are semantically not constants. Instead, they provide access to external value sources and should thus be scoped as special language variables comparable to the C-like `this` or Python's `self`.
Scope name was inspired by Python.
`in` is a proper keyword here, not an operator.
Having basically a copy of the test file for the identical terraform syntax is quite redundant. Instead, only test for a few excerpts of that syntax to ensure the inclusion works as expected.
|
I also dropped the commit that uses |
In this time of supply chain risk, it's worth making sure that the claims are true regarding package transfer, but FF is legitimate and so is the GitHub org in question. |
Trying out the syntax for the first time, I couldn't help but notice that several wrong colors were being used to highlight text, which was caused by questionable, non-standard or outdated scope names.
The commits included in this PR should mostly stand on their own, i.e. I can be cherry-picked or omitted if desired, though I stand by each change being an improvement.
Note that 843b9bf requires ST4 (but can also just be omitted).Edit: dropped the commit