Adamg/flashdrivertest #90

b-atteryacid · 2024-05-02T02:34:57Z

Flash Driver Improvements
Documentation

…ion.

… speed and decrease flash usage. Pressure transducer samples and logs to flash at 1kHz, but only currently transmits every 50 pressure transducer logs. Other sensors log to flash every 40ms. Added debug logs to change logging rate, debug timing messages, etc. New page offset flash recovery for hardfaults.

… for PTC, baro, gps, and imu. Not every PTC log results in a telemetry send.

- Flash Task secondary queue for priority messages - Stops logging when flash full - Recovers and resumes from last written flash page on reset - Command "rstflsh <num>" to erase num sectors and start at beginning of log space

- Fixed bug where rstflsh would not reset flash page offset storage

cjchanx

Please refactor the flash logging functionality into a new class / object that initializes at a specific sector offset for a specific size (probably in sectors) as parameters. As a rough example make it an object somewhat similar to SimpleDualSectorStorage in how it wraps flash functionality (in FlashTask you create one object of this new FlashLogStorage and interface with it using that object).

This would help contain all the functionality in one class, make it easier to move to other boards, and use.

cjchanx · 2024-05-23T01:04:59Z

Components/Core/Queue.cpp

@@ -58,6 +58,7 @@ bool Queue::SendToFront(Command& command)
    if (xQueueSendToFront(rtQueueHandle, &command, DEFAULT_QUEUE_SEND_WAIT_TICKS) == pdPASS)
        return true;

+


Cleanup empty lines

cjchanx · 2024-05-23T01:05:12Z

Components/Flash/Driver/w25qxx.hpp

@@ -96,6 +96,7 @@ extern "C"
 	void W25qxx_WritePage(uint8_t *pBuffer, uint32_t Page_Address, uint32_t OffsetInByte, uint32_t NumByteToWrite_up_to_PageSize);
 	void W25qxx_WriteSector(uint8_t *pBuffer, uint32_t Sector_Address, uint32_t OffsetInByte, uint32_t NumByteToWrite_up_to_SectorSize);
 	void W25qxx_WriteBlock(uint8_t *pBuffer, uint32_t Block_Address, uint32_t OffsetInByte, uint32_t NumByteToWrite_up_to_BlockSize);
+	void W25qxx_WritePageScary(uint8_t *pBuffer, uint32_t Page_Address);


Change IDE to 4-space tabs, get rid of this function declaration unless it's used somewhere

cjchanx · 2024-05-23T01:06:14Z

Components/Flash/FlashTask.cpp

@@ -4,7 +4,7 @@
 * Description        : Flash interface task. Used for logging, writing to system
 *                      state, and flash maintenance operations for the system.
 ******************************************************************************
-*/
+ */


Cleanup random spaces

cjchanx · 2024-05-23T01:06:54Z

Components/Flash/FlashTask.cpp

@@ -15,173 +15,745 @@
 #include "Data.h"
 #include <cstring>

+
+#define min(a,b) ((a)>(b) ? (b):(a))


Macros should be all caps

cjchanx · 2024-05-23T01:09:09Z

Components/Flash/FlashTask.cpp

+FlashTask::FlashTask() : Task(FLASH_TASK_QUEUE_DEPTH_OBJS) {
+	logbufA = (uint8_t*) soar_malloc(FLASH_HEAP_BUF_SIZE);
+	logbufB = (uint8_t*) soar_malloc(FLASH_HEAP_BUF_SIZE);
+	currbuf = logbufA;


Convert from tabs to 4-spaces

shivamdesai04 · 2024-05-23T01:06:54Z

Components/Core/Queue.cpp

@@ -58,6 +58,7 @@ bool Queue::SendToFront(Command& command)
    if (xQueueSendToFront(rtQueueHandle, &command, DEFAULT_QUEUE_SEND_WAIT_TICKS) == pdPASS)
        return true;

+


Remove this white space

shivamdesai04 · 2024-05-23T01:06:57Z

Components/Flash/Driver/SPIFlash.hpp

+
+

remove this white space

shivamdesai04 · 2024-05-23T01:06:58Z

Components/Flash/Driver/w25qxx.cpp

@@ -640,6 +640,8 @@ void W25qxx_WriteByte(uint8_t pBuffer, uint32_t WriteAddr_inBytes)
 #endif
 	w25qxx.Lock = 0;
 }
+


remove one line from this whitespace

shivamdesai04 · 2024-05-23T01:07:33Z

Components/Flash/Driver/w25qxx.hpp

@@ -96,6 +96,7 @@ extern "C"
 	void W25qxx_WritePage(uint8_t *pBuffer, uint32_t Page_Address, uint32_t OffsetInByte, uint32_t NumByteToWrite_up_to_PageSize);
 	void W25qxx_WriteSector(uint8_t *pBuffer, uint32_t Sector_Address, uint32_t OffsetInByte, uint32_t NumByteToWrite_up_to_SectorSize);
 	void W25qxx_WriteBlock(uint8_t *pBuffer, uint32_t Block_Address, uint32_t OffsetInByte, uint32_t NumByteToWrite_up_to_BlockSize);
+	void W25qxx_WritePageScary(uint8_t *pBuffer, uint32_t Page_Address);


Fix the name. Dont have it as Write scary page, unless it means something

shivamdesai04 · 2024-05-23T01:08:54Z

Components/Flash/Inc/FlashTask.hpp

 };

+enum FLASH_LOG_TYPE { // at most 8 types
+	LTYPE_INVAL,


Make the first one explicitly equals to 0

shivamdesai04 · 2024-05-23T01:08:55Z

Components/Flash/Inc/FlashTask.hpp

+    WRITE_DATA_TO_FLASH = 0x01, // The top 3 bits of this contain the ID of the log type to be logged
+    DUMP_FLASH_DATA = 0x02,
+    ERASE_ALL_FLASH = 0x03,
+	GET_FLASH_OFFSET = 0x04,
+	FLASH_DUMP_AT = 0x05,
+	FLASH_RESET_AND_ERASE = 0x06,
+	GET_LOGS_PAST_SECOND = 0x07,
+	GET_PAGE_OFFSET = 0x08,
+	FLASH_READ_FIRST_LOGS = 0x09,
+	TOG_BUFLOGS = 0x0A


you dont have to specify the number after the first one. Might make the code look cleaner.

shivamdesai04 · 2024-05-23T01:09:52Z

Components/Flash/Inc/FlashTask.hpp

+	GET_LOGS_PAST_SECOND = 0x07,
+	GET_PAGE_OFFSET = 0x08,
+	FLASH_READ_FIRST_LOGS = 0x09,
+	TOG_BUFLOGS = 0x0A
 };



write a comment here saying these are the different log types

Cleaned up whitespace and switched to 4-space tabs Removed unused function declaration Cleaned up values of some flash enums

b-atteryacid added 7 commits October 28, 2023 13:17

70Hz, no offset updates

19613a6

flash 1.5khztest with delta compression, sensor bottleneck 75Hz max

28c17df

1000Hz PTC sampling and flash logging, but NO PTC telemetry transmiss…

76f3d20

…ion.

Support for python scraping and graphing of dumps. Full functionality…

412f88f

… for PTC, baro, gps, and imu. Not every PTC log results in a telemetry send.

- Add page-wise 2-byte checksum for flash logs

a8a259a

- Flash Task secondary queue for priority messages - Stops logging when flash full - Recovers and resumes from last written flash page on reset - Command "rstflsh <num>" to erase num sectors and start at beginning of log space

- Fixed bug where only up to 1012 sectors could be cleared by rstflsh

c857c1d

- Fixed bug where rstflsh would not reset flash page offset storage

cjchanx requested changes May 23, 2024

View reviewed changes

shivamdesai04 reviewed May 23, 2024

View reviewed changes

b-atteryacid added 2 commits May 29, 2024 19:29

Refactored flash logging into separate class

a5cbd5b

Cleaned up whitespace and switched to 4-space tabs Removed unused function declaration Cleaned up values of some flash enums

Re-enabled buzzer by default

1382a8f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adamg/flashdrivertest #90

Adamg/flashdrivertest #90

b-atteryacid commented May 2, 2024

cjchanx left a comment

cjchanx May 23, 2024

cjchanx May 23, 2024

cjchanx May 23, 2024

cjchanx May 23, 2024

cjchanx May 23, 2024

shivamdesai04 May 23, 2024

shivamdesai04 May 23, 2024

shivamdesai04 May 23, 2024

shivamdesai04 May 23, 2024

shivamdesai04 May 23, 2024

shivamdesai04 May 23, 2024

shivamdesai04 May 23, 2024

		@@ -58,6 +58,7 @@ bool Queue::SendToFront(Command& command)
		if (xQueueSendToFront(rtQueueHandle, &command, DEFAULT_QUEUE_SEND_WAIT_TICKS) == pdPASS)
		return true;

Adamg/flashdrivertest #90

Are you sure you want to change the base?

Adamg/flashdrivertest #90

Conversation

b-atteryacid commented May 2, 2024

cjchanx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment