Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

[Fix] TourAPI 내 식별자 부재에 대한 처리 로직 추가 #216

Merged
merged 3 commits into from
Jan 27, 2024

Conversation

laigasus
Copy link
Member

@laigasus laigasus commented Jan 27, 2024

변경사항

장소 목록 중에서 contentId, areaCode, sigunguCode 가 없는 데이터에 대한 처리 로직이 구현되었습니다.
우편번호(zipCode) 가 Integer -> String 으로 변경되었습니다

BREAK CHANGES: place 엔티티 내 zipCode 타입이 변경되어 운영환경 DB에 작업이 필요합니다. api 문서 최신화 필수

Issue Link - #215

체크리스트

  • 식별자 값에 이상이 있으면 해당 데이터는 제외하고 서빙하나요?
  • 가공 과정(DomainConverter)에서의 문제가 해결되었나요?
  • 충분한 검증을 수행했나요?

참고

스크린샷 2024-01-28 020719
스크린샷 2024-01-28 020741

`#` 자료유형 Integer -> String
`+` 식별자로 사용되는 키 값들 중 하나라도 없으면 건너뜀

아래의 수행에서만 유효함:
- 인접장소 목록
- 검색 결과
@laigasus laigasus added the bug Something isn't working label Jan 27, 2024
@laigasus laigasus requested review from happymink and Dr-KoKo January 27, 2024 17:09
@laigasus laigasus self-assigned this Jan 27, 2024
Copy link

github-actions bot commented Jan 27, 2024

Test Results

37 tests  ±0   37 ✅ ±0   2s ⏱️ ±0s
15 suites ±0    0 💤 ±0 
15 files   ±0    0 ❌ ±0 

Results for commit 8a0b2c8. ± Comparison against base commit 09ffda4.

♻️ This comment has been updated with latest results.

@laigasus laigasus requested a review from NoJaeHyuk January 27, 2024 18:35
@laigasus laigasus removed the request for review from NoJaeHyuk January 27, 2024 21:11
Copy link
Contributor

@happymink happymink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@laigasus laigasus merged commit d27bf56 into develop Jan 27, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] PlaceService의 saveOrUpdatePlace 호출시 간헐적인 IllegalArgumentException
3 participants