Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom scrollbar & Clickable address phone #21

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions assets/scss/_scrollbar.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/* Webkit Scrollbar Customize */
::-webkit-scrollbar-thumb {
background: $primary;

&:hover {
background: $secondary;
}
}

::-webkit-scrollbar {
width: 5px;
background: #fff;
}
2 changes: 2 additions & 0 deletions assets/scss/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ VERSION: 1.0.0

@import "common";

@import "scrollbar";

@import "components/preloder";

@import "components/navbar";
Expand Down
5 changes: 3 additions & 2 deletions layouts/contact/list.html
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ <h4>Office Address</h4>
</div>
</div>
<h4>Phone & Email</h4>
<p>{{ $address.phone }}<br>
<p>
Copy link
Contributor

@jbleduigou jbleduigou Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the <br> tag and instead rely on two <p>[...]</p> blocks?

Copy link
Author

@hervyqa hervyqa Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer keep <br>. because if remove <br> became like this.

Screenshot_20201101_140359
Screenshot_20201101_140415

<a href="tel:{{ $address.phone }}">{{ $address.phone }}</a><br>
<a href="mailto:{{ $address.email }}">{{ $address.email }}</a>
</p>

Expand Down Expand Up @@ -187,4 +188,4 @@ <h3>Contact Form</h3>
</div>
</section>

{{ end }}
{{ end }}