Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom scrollbar & Clickable address phone #21

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add custom scrollbar & Clickable address phone #21

wants to merge 8 commits into from

Conversation

hervyqa
Copy link

@hervyqa hervyqa commented Oct 28, 2020

Screenshot_20201029_065337

@hervyqa hervyqa changed the title Add custom scrollbar Add custom scrollbar & Clickable address phone Oct 29, 2020
@jbleduigou
Copy link
Contributor

It is a great idea to make the phone number clickable!

@@ -75,7 +75,8 @@ <h4>Office Address</h4>
</div>
</div>
<h4>Phone & Email</h4>
<p>{{ $address.phone }}<br>
<p>
Copy link
Contributor

@jbleduigou jbleduigou Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the <br> tag and instead rely on two <p>[...]</p> blocks?

Copy link
Author

@hervyqa hervyqa Nov 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer keep <br>. because if remove <br> became like this.

Screenshot_20201101_140359
Screenshot_20201101_140415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants