Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] remove unnecessary replicate for outer_common_expr #52649

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[BugFix] remove unnecessary replicate for outer_common_expr #52649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions be/src/exprs/array_map_expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,28 +139,8 @@ StatusOr<ColumnPtr> ArrayMapExpr::evaluate_lambda_expr(ExprContext* context, Chu
}
DCHECK(aligned_offsets != nullptr);

// 4. prepare outer common exprs
for (const auto& [slot_id, expr] : _outer_common_exprs) {
auto column = chunk->get_column_by_slot_id(slot_id);
column = ColumnHelper::unpack_and_duplicate_const_column(column->size(), column);
if constexpr (independent_lambda_expr) {
// if lambda expr doesn't rely on arguments, we don't need to align offset
cur_chunk->append_column(column, slot_id);
} else {
if (column->is_array()) {
auto view_column = ArrayViewColumn::from_array_column(column);
cur_chunk->append_column(view_column->replicate(aligned_offsets->get_data()), slot_id);
} else {
cur_chunk->append_column(column->replicate(aligned_offsets->get_data()), slot_id);
}
}
}

// 5. prepare capture columns
// 4. prepare capture columns
for (auto slot_id : capture_slot_ids) {
if (cur_chunk->is_slot_exist(slot_id)) {
continue;
}
auto captured_column = chunk->get_column_by_slot_id(slot_id);
if constexpr (independent_lambda_expr) {
cur_chunk->append_column(captured_column, slot_id);
Expand All @@ -174,7 +154,7 @@ StatusOr<ColumnPtr> ArrayMapExpr::evaluate_lambda_expr(ExprContext* context, Chu
}
}

// 6. evaluate lambda expr
// 5. evaluate lambda expr
ColumnPtr column = nullptr;
if constexpr (independent_lambda_expr) {
// if lambda expr doesn't rely on arguments, we evaluate it first, and then align offsets
Expand Down
Loading