Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] remove unnecessary replicate for outer_common_expr #52649

Merged

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Nov 5, 2024

Why I'm doing:

What I'm doing:

correction from #52598
outer_common_expr may refer to the result of another outer_common_expr , but not every one of them is needed for the lambda expression evaluation. We only need to replicate the final captured column.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@silverbullet233 silverbullet233 requested a review from a team as a code owner November 5, 2024 13:29
@github-actions github-actions bot added the 3.3 label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 6, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 6, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@silverbullet233 silverbullet233 enabled auto-merge (squash) November 6, 2024 06:45
@silverbullet233 silverbullet233 merged commit ee085bf into StarRocks:main Nov 6, 2024
59 of 63 checks passed
@silverbullet233 silverbullet233 deleted the remove_unnecessary_replicate branch November 6, 2024 10:58
Copy link

github-actions bot commented Nov 6, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 6, 2024
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit ee085bf)
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@silverbullet233
Copy link
Contributor Author

@mergify backport branch-3.2

Copy link
Contributor

mergify bot commented Nov 15, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 15, 2024
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit ee085bf)

# Conflicts:
#	be/src/exprs/array_map_expr.cpp
wanpengfei-git pushed a commit that referenced this pull request Nov 15, 2024
…52649) (#52935)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants