-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure suggestion #23
Conversation
@Dolu1990 you started a review, so do I assume agreement on the structure? So:
|
One issue is the MyTopLevel folder :
So it realy has to be removed |
Wilco for Other things to change? Can I start documenting? |
For Maybe we should have this, which generates all by default, and depending on the synthesis tool used the users can remove the ones they don't need? object MyTopLevelGen extends App {
config.spinal.generateVerilog(MyTopLevel())
config.spinal.generateVhdl(MyTopLevel())
} |
So this and the other topics which were already opened, that's all ^^
Not an issue they can be both into MyTopLevelGen.scala
Hmmm i think the best is to keep a Verilog and a Vhdl object instead of running two time the generation (which is something that normaly nobody do) |
Tested with mill running:
|
2ce6b34
to
57ab4aa
Compare
Rebased to clean history. @Dolu1990 for merging |
1b9e6f2
to
4849860
Compare
@Dolu1990 I added two little commits as the PR is still open, but it can be merged I think |
Nice, thanks :) |
Draft structure suggestion according to SpinalHDL/SpinalDoc-RTD#147
There are no unit / regression tests yet; I won't add anything for that before SpinalHDL/SpinalHDL#965 is merged and released (feedback welcome btw), or closed.
Don't merge before: