-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor step 1 #150
Refactor step 1 #150
Conversation
If the refactor is necessary, I suggest that add a "Design philosophy" behind the "A simple example" section. |
Yes we should add that, but I think it would go in the introduction? Between What is SpinalHDL and Advantages …? |
In presentation.pdf, there is the page 4 which can be good to explain that (with a diagram) |
Tbh I think this PR is big enough for a review, I can open an issue to do that in a subsequent PR @Readon ? |
As a reader, an example is much more useful at first. Later than that, a deeper explanation can help to understand. |
Yea this is the goad of this refactoring, here is just the very beginning. So there would be an example in the introduction, and then a kind of little at the end of Getting Started? |
Do we have the sources of the 2 pdf files? So that I could maybe simply extract visual contents as svg's? |
A simple example <3 |
About the final structure to give, I have sent a suggestion in #151 I think all discussions about parts of the structure which are not modified yet, and sections to add should be in #151. |
SpinalDevFlow.png extracted from presentation.pdf
I have updated after your suggestions, I still need answers for the remaining questions in the description |
About the activities, I think bootcamp and workshop is still working. |
Bootcamp: It is a fork of a @jijingg repository, and the fork is a few commits late… Maybe we could move the original repository to maintain it all together as a part of Spinal repositories? Also I found that it (the fork) uses version 1.6.0 https://github.com/SpinalHDL/Spinal-bootcamp/blob/dev/exercises/build.sc#L5 Workshop is less late, 1.7.0a https://github.com/SpinalHDL/SpinalWorkshop/blob/workshop/build.sbt#L6 So tell me if I am wrong, I can define the workshop as a set of exercises (maybe I can point to exercises all along the tutorial part?), and bootcamp as an interactive tutorial? |
They are all tutorials, and they don't necessarily need to be updated to the latest often, as long as the API remains the same. ^^ |
Thanks, updated. For StackOverflow and Google groups, are there people still using them? For the last point, an agreement about #147 ( Also don't forget, it would be nice to have references about companies using SpinalHDL (for instance an article explaining what they do, why they use SpinalHDL and such things). |
The thing about maintenance and maintained code, is that man power is realy low in general, can't keep everything all the time up to the last revision, as it take time to update / test / verify. So in some way, it is sometime better to keep things in a state they were known to work, than updating and silently breaking stuff. |
It is mostly use as a way to push notification so far XD |
Yea, this is why I documented these other tutorials as not having the latest features in my last commits. For Google groups, as long as a new user sending a question there gets an answer it is okay for me ^^ And for Stackoverflow? Do I remove it? |
Ah, one more thing: https://github.com/SpinalHDL/Spinal-bootcamp being a fork has a maintenance cost that it needs to be sync'd by-hand. And if we don't sync we waste maintenance of the person who added commits to it. So maybe we could ask to move the original repository instead of having a fork, or directly point to the original repository? |
yes. |
All the TODOs are checked, but please don't merge before SpinalHDL/SpinalTemplateSbt#23 is merged. I have removed the "reference needed" for this PR but it would still be better if we had some |
The template has been updated so I think this PR can be merged now. |
https://numero-744.github.io/SpinalDoc-RTD/master/SpinalHDL/Introduction/Getting%20in%20touch.html need a bit of work i think. I would say : Google group is used as a mailing list to get notification when there is a event or something. Stackoverflow, i realy have no idea, i'm not sure it is worth mentioning it, as there is nothing special there ? |
(else i think this look good ^^) |
Good to me. |
@Dolu1990 Sorry I forgot to update https://numero-744.github.io/SpinalDoc-RTD/master/ it should be okay now (reloading the page may be needed) https://numero-744.github.io/SpinalDoc-RTD/master/SpinalHDL/Introduction/Getting%20in%20touch.html |
Ahhh right ^^ |
This is the first part of my refactoring work.
You can see it live on https://numero-744.github.io/SpinalDoc-RTD/master/
For review I suggest to visit the site and the first pages of the PDF. I stopped just before 2.6 Scala Guide.
Things to discuss:
reference needed
tag)StackOverflow
maintained? Do we have a better link than juststackoverflow.com
?taste.pdf
(ormotivation.pdf
, I think it is the same file)Close #149 and #147