Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize while iterating over syncronizedList in CommandSend #3547

Closed
wants to merge 4 commits into from
Closed

synchronize while iterating over syncronizedList in CommandSend #3547

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e66b81b
synchronize while iterating syncronizedList in CommandSend
Outfluencer Oct 9, 2023
a6323b0
Update CommandSend.java
Outfluencer Oct 9, 2023
689f094
make count atomic
Outfluencer Oct 28, 2023
605da4a
synchronize full use of the value
Outfluencer Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions module/cmd-send/src/main/java/net/md_5/bungee/module/cmd/send/CommandSend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ public void lastEntryDone()
ComponentBuilder builder = new ComponentBuilder( "" );
if ( !entry.getValue().isEmpty() )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be synchronised from here and also down below to when entry.getValue stops being used (ie put value in a local and synchronise it)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it only needs to be synchronized while iterating, that is only the case in the joiner call

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ordinarily getValue.isEmpty could change, but if this method is the last entry then that suggests no synchronisation is actually needed at all (although callback.count should be atomic?)

{
builder.event( new HoverEvent( HoverEvent.Action.SHOW_TEXT,
new ComponentBuilder( Joiner.on( ", " ).join( entry.getValue() ) ).color( ChatColor.YELLOW ).create() ) );
String text;
synchronized ( entry.getValue() )
{
text = Joiner.on( ", " ).join( entry.getValue() );
}
builder.event( new HoverEvent( HoverEvent.Action.SHOW_TEXT, new ComponentBuilder( text ).color( ChatColor.YELLOW ).create() ) );
}
builder.append( entry.getKey().name() + ": " ).color( ChatColor.GREEN );
builder.append( "" + entry.getValue().size() ).bold( true );
Expand Down