synchronize while iterating over syncronizedList in CommandSend #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
md-5
reviewed
Oct 16, 2023
| @@ -50,8 +50,12 @@ public void lastEntryDone() | |||
| ComponentBuilder builder = new ComponentBuilder( "" ); | |||
| if ( !entry.getValue().isEmpty() ) | |||
There was a problem hiding this comment.
Shouldn't it be synchronised from here and also down below to when entry.getValue stops being used (ie put value in a local and synchronise it)
There was a problem hiding this comment.
I thought it only needs to be synchronized while iterating, that is only the case in the joiner call
There was a problem hiding this comment.
Well ordinarily getValue.isEmpty could change, but if this method is the last entry then that suggests no synchronisation is actually needed at all (although callback.count should be atomic?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3529