-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: ERS - segment length - convert to float #7400
Merged
SoftFever
merged 10 commits into
SoftFever:main
from
igiannakas:Optimisation-Enable-ERS-segment-length-down-to-0.5mm
Jan 5, 2025
Merged
Enhancement: ERS - segment length - convert to float #7400
SoftFever
merged 10 commits into
SoftFever:main
from
igiannakas:Optimisation-Enable-ERS-segment-length-down-to-0.5mm
Jan 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow splitting of line segments down to 0.5mm for improved external surface finish.
igiannakas
changed the title
Enhancement: ERS segment length - convert to float
Enhancement: ERS - segment length - convert to float
Nov 6, 2024
…ngth-down-to-0.5mm
…ngth-down-to-0.5mm
…ngth-down-to-0.5mm
This was referenced Nov 29, 2024
SoftFever
previously approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you
SoftFever
approved these changes
Jan 5, 2025
igiannakas
deleted the
Optimisation-Enable-ERS-segment-length-down-to-0.5mm
branch
January 5, 2025 17:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow splitting of line segments down to 0.5mm for improved external surface finish. Also added unit of measure (mm) to the segment length variable.
Old user profile values migrate correctly without impact.
If merged, ideally they should be done in this order to reduce possibility of conflicts in GitHub:
#7398
#7399
#7400