-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: ERS - Option to limit ERS to external perimeters and overhangs only #7399
base: main
Are you sure you want to change the base?
Enhancement: ERS - Option to limit ERS to external perimeters and overhangs only #7399
Conversation
Hi, sounds as really cool feature! |
Yes I have them all on my dev branch here: https://github.com/igiannakas/OrcaSlicer/actions/runs/11783977166 |
Hi, @igiannakas . I tested a bit the build with your modifications. |
Nope it should only be applied to external perimeters specifically for overhang regions. To avoid artefacts from rapid acceleration and deceleration when moving in and away from sharp overhangs. |
These look perfect! Well done on taming the S1!! |
Hi. Found a bit of strange behaviour when the ERS is switched on. (build #7399 (comment)) Strong slowdowns in a couple of places where it doesn't seem to be needed, after a seam. Print movements and flow is not different from other layers. BUT I haven't checked this behaviour on the Main release build of Orca yet, maybe it's a general ERS bug. (haven't had time yet). |
Are you using scarf seam? I’ll take a look at the project probably next week. would you mind in the meantime time cross checking against the latest stable release too please? |
Tested this. |
Cool no worries, thank you for helping pin point it. I was concerned that the segment simplification would have caused this but it’s “good” to see it’s present in the release version - that means it’s unrelated :) |
Huh… that makes no sense!! Something is triggering a boundary condition that is not triggered when slightly higher flow exists is my guess. It would be good to see that specific layer and more specifically the move that is before the external perimeter. |
Yeah, something like that one. But one can definitely say that this or these problems are clearly somewhere outside of this Pull request. I will describe them rather for formality in spoiler below: Details under spoiler: On an interesting note about this strange behavior with pics:On an interesting note: the roots of the problem go somewhere in the bowels of Orca and\or Arachne. (When Flow == 1.01)
|
Description
Extrusion rate smoothing can materially help smooth out speed transitions during overhangs, leading to better external finish. This is similar to the latest bambu slicer release where speed transition smoothing has been introduced.
However current implementation applies smoothing to all features which will increase print time with marginal benefit visually.
Therefore, this PR introduces an option to limit ERS to the areas that are visible to the user, reducing print time impact.
Debating whether to enable this option by default when ERS is enabled, as internal features do not benefit much from extrusion rate smoothing compared to slowdown for overhangs that does materially benefit especially for printers with high accelerations, where PA cannot keep up with the requested speed changes over time.
If merged, ideally they should be done in this order to reduce possibility of conflicts in GitHub:
#7398
#7399
#7400
Screenshots/Recordings/Graphs
Tests
Basic regression tests done-no adverse impact with it disabled to the existing feature. Enabled limits only to external perimeters & overhangs.