ENH: Experimental option to fully disable solid infill against walls when ensure vertical thickness is turned off - alternative implementation #3285
Conversation
…l when ensure vertical thickness is turned off.
…nnakas/OrcaSlicer into pr-reduce-wall-solid-infill
Co-Authored-By: Vovodroid <[email protected]>
|
This PR is exactly what I expected. It works very well, it seems. This is without further reduce solid infill on walls. Seven top layers set. Nine top layers are generated (including the supporting one). 
This is with further reduce solid infill on walls enabled. Seven top layers set. Eight top layers are generated (including the supporting one). 
And in any case the algorithm seems to work correctly where the inclinations are less accentuated. 
I'd say the problem seems solved. Thank you so much. |
|
@igiannakas , hey, I haven't had time to focus on this test since after the first run I shared with you on discord. Thank you so much for looking into this 🙏 |
|
And again, the algorithm also takes into account the top shell thickness. So if the object is printed with variable layer height, if the top shell thickness parameter is set, it is correctly applied when the number of top layers does not guarantee the desired thickness. |
|
Excellent. so sounds like this PR is the way to go! I've marked the other one as "to-delete" but retaining it in case its ever needed. |
|
It seems that this is the better approach :) Good job, great feedback |
| @@ -481,6 +470,18 @@ void PrintObject::prepare_infill() | |||
| this->discover_horizontal_shells(); | |||
| m_print->throw_if_canceled(); | |||
|
|
|||
| // this will detect bridges and reverse bridges | |||
There was a problem hiding this comment.
Any reason to move this code block?
There was a problem hiding this comment.
yeap, it fixes an issue with bridging over small holes that I found while making this PR.
If processed horizontal shells is done after the external surfaces processing, when the ensure vertical thickness option is disabled the bridges dont expand like when the ensure vertical shell thickness option is turned on. This results in the bridges collapsing inside small holes, like the bottom bridge layer of the benchy.
Before moving the code block (current V1.9 release)
After moving the code block:
With vertical thickness enabled:
|
@SoftFever again I'm not too happy with this PR (my yardstick is whether I'd be happy to have it turned on all the time). While it works great in retaining thickness with slanted surfaces, It creates issues with flat top surfaces which are way too common to ignore as an issue: Layer 39 Layer 40: Basically a one layer top surface... That is a no-go for me for this PR. I'll revert to the original version here: #3235 And look at tweaking the parameters a bit to tune out the issue with heavily sloped surfaces |
This PR achieves the same outcome as #3235 only with a different implementation approach.
This one eliminates slightly less vertical infill however it is safer as it retains more of the top slanted surface infill to address issues like the below: #3235 (comment)
@liftbag @ShryuKt @HakunMatat4 please test when you can.
Disabled:
First implementation:
#3235
This PR:
Heavily sloped model:
Disabled
First implementation:
This PR
Solid infill is generated to support the top surface