Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kor translation update #2991

Merged
merged 1 commit into from
Dec 6, 2023
Merged

kor translation update #2991

merged 1 commit into from
Dec 6, 2023

Conversation

crwusiz
Copy link
Contributor

@crwusiz crwusiz commented Dec 4, 2023

No description provided.

@SoftFever
Copy link
Owner

@crwusiz
Thanks, can you take a look that these errors?

Run echo $PWD
/home/runner/work/OrcaSlicer/OrcaSlicer
./localization/i18n/ko/OrcaSlicer_ko.po:6604:43: syntax error
./localization/i18n/ko/OrcaSlicer_ko.po:11984: missing 'msgstr' section
./localization/i18n/ko/OrcaSlicer_ko.po:11985:2: syntax error
msgfmt: found 3 fatal errors
Error: Process completed with exit code 1.

@crwusiz
Copy link
Contributor Author

crwusiz commented Dec 5, 2023

@crwusiz Thanks, can you take a look that these errors?

Run echo $PWD
/home/runner/work/OrcaSlicer/OrcaSlicer
./localization/i18n/ko/OrcaSlicer_ko.po:6604:43: syntax error
./localization/i18n/ko/OrcaSlicer_ko.po:11984: missing 'msgstr' section
./localization/i18n/ko/OrcaSlicer_ko.po:11985:2: syntax error
msgfmt: found 3 fatal errors
Error: Process completed with exit code 1.

sorry..i fix this...!

@SoftFever
Copy link
Owner

@crwusiz
Thank you!
Could you also take a look at the conflicts?

@crwusiz crwusiz force-pushed the main_ko branch 2 times, most recently from c021cba to d29c09b Compare December 5, 2023 14:08
@crwusiz
Copy link
Contributor Author

crwusiz commented Dec 5, 2023

#, c-format, boost-format
msgid ""
"Density of internal sparse infill, 100% turns all sparse infill into solid "
"infill and internal solid infill pattern will be used"
msgstr ""
"내부 드문 채우기의 밀도, 100% tu모든 드문 채우기를 솔리드로 바꿉니다 채우기 "
"및 내부 솔리드 채우기 패턴이 사용됩니다"

=====================
If you do not enter the 100% turns translation as 100% tu, an error will occur

I think we need to change the turn's word so that it doesn't crash in the c-format.

@SoftFever
Copy link
Owner

#, c-format, boost-format msgid "" "Density of internal sparse infill, 100% turns all sparse infill into solid " "infill and internal solid infill pattern will be used" msgstr "" "내부 드문 채우기의 밀도, 100% tu모든 드문 채우기를 솔리드로 바꿉니다 채우기 " "및 내부 솔리드 채우기 패턴이 사용됩니다"

===================== If you do not enter the 100% turns translation as 100% tu, an error will occur

I think we need to change the turn's word so that it doesn't crash in the c-format.

We can also remove this line so that it won't complain
#, c-format, boost-format

fix

remove c-format

fix typo

fix
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SoftFever SoftFever merged commit ca4c75f into SoftFever:main Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants