Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wxWidgets to v3.2.1 #2905

Merged
merged 60 commits into from
Dec 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
2302245
Upgrade wxWidgets to 3.2.1
Ocraftyone Nov 3, 2023
961629b
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Nov 5, 2023
a977c69
Implement BitmapCache
Ocraftyone Nov 7, 2023
e114881
update wxExtensions while keeping legacy items
Ocraftyone Nov 7, 2023
cdff9ba
update dc.DrawBitmap calls to use get_bitmap
Ocraftyone Nov 7, 2023
77a143a
Fix GetSize/Width/Height calls
Ocraftyone Nov 7, 2023
eba3fe2
update BitmapComboBox
Ocraftyone Nov 7, 2023
d4676ee
fix ifndef in wxExtensions.hpp
Ocraftyone Nov 7, 2023
dc062f1
update my todos to OcraftyoneTODO
Ocraftyone Nov 7, 2023
03754b5
Get to a compilable state
Ocraftyone Nov 8, 2023
7acae72
fix extruder color icons
Ocraftyone Nov 8, 2023
92c9a53
fix crash on opening support tab
Ocraftyone Nov 8, 2023
7cfa854
remove GetBmpSize method from DropDown.cpp
Ocraftyone Nov 8, 2023
510a4a0
Update TextInput to use bitmap bundles
Ocraftyone Nov 8, 2023
6d149e0
update a TODO after testing
Ocraftyone Nov 8, 2023
413e875
fix the rendering of the icons on combobox
Ocraftyone Nov 8, 2023
506e1f4
fix a few todos
Ocraftyone Nov 9, 2023
c9284cc
fix WipeTowerDialog.cpp
Ocraftyone Nov 11, 2023
553f72a
Overhaul WipeTowerDialog
Ocraftyone Nov 13, 2023
62d689b
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Nov 13, 2023
cbbeb55
update a few todos
Ocraftyone Nov 13, 2023
3f0083c
Update some todos
Ocraftyone Nov 19, 2023
6e7dfc5
Show dropdown when editing is started
Ocraftyone Nov 19, 2023
7b1f49f
Update NanoSVG.cmake
Ocraftyone Nov 19, 2023
53bc949
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Nov 20, 2023
bc21ab6
Dim the icon on ComboBox when disabled
Ocraftyone Nov 21, 2023
5162232
solve ObjectDataViewModel todos
Ocraftyone Nov 22, 2023
3b5c571
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Nov 22, 2023
01398dd
Update names in wxExtensions
Ocraftyone Nov 22, 2023
3a3301b
update BitmapCache::from_svg
Ocraftyone Nov 22, 2023
2b9cb53
Update ScalableButton
Ocraftyone Nov 22, 2023
7f83f46
fix up some more todos in wxExtensions
Ocraftyone Nov 22, 2023
8a0b395
update ScalableBitmap to use bmp bundles
Ocraftyone Nov 23, 2023
d9c20b5
attempt to fix macos deps build
Ocraftyone Nov 25, 2023
0944c42
fix ubuntu build
Ocraftyone Nov 25, 2023
0e2f88d
Revert "attempt to fix macos deps build"
Ocraftyone Nov 27, 2023
bbf9b5f
update wxWidgets patch
Ocraftyone Nov 27, 2023
a3d292f
Remove duplicate variable from OrcaSlicer.cpp
Ocraftyone Nov 27, 2023
8e26df2
Fix macOS build issue
Ocraftyone Nov 27, 2023
d13bbb1
Fix blank DataViewItem being added to objects list
Ocraftyone Nov 27, 2023
07a637d
Filament ComboBox editor updates
Ocraftyone Nov 27, 2023
03f000a
remove Apple specific declarations missed during refactor
Ocraftyone Nov 28, 2023
fbf97cd
delete old wxWidgets patch
Ocraftyone Nov 28, 2023
6a97dfc
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Nov 28, 2023
cfc67dd
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Nov 29, 2023
6835f87
fix ubuntu seg fault
Ocraftyone Nov 30, 2023
308eeff
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Nov 30, 2023
4308fad
include patch from #2926
Ocraftyone Nov 30, 2023
d70a0f0
Merge remote-tracking branch 'ocraftyone_origin/enh-update-wxwidgets'…
Ocraftyone Nov 30, 2023
5ad3ce7
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Dec 1, 2023
887ab5d
update patch to include wxWidgets/wxWidgets@991a74c
Ocraftyone Dec 1, 2023
1b48a9b
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Dec 1, 2023
6312da2
fix deps not compiling on Windows
Ocraftyone Dec 1, 2023
cd95c8d
update WipeTowerDialog
Ocraftyone Dec 1, 2023
76ac529
finish patching wxWidgets
Ocraftyone Dec 1, 2023
30ac3fe
fix combobox crash
Ocraftyone Dec 3, 2023
c4f64fb
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Dec 3, 2023
1b24e19
Merge branch 'main' into enh-update-wxwidgets
Ocraftyone Dec 4, 2023
fd436ea
revert outside plate changes
Ocraftyone Dec 4, 2023
737427d
Merge remote-tracking branch 'origin/enh-update-wxwidgets' into enh-u…
Ocraftyone Dec 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deps/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ endif ()

include(JPEG/JPEG.cmake)
include(TIFF/TIFF.cmake)
include(NanoSVG/NanoSVG.cmake)
include(wxWidgets/wxWidgets.cmake)
include(OCCT/OCCT.cmake)
include(FREETYPE/FREETYPE.cmake)
Expand Down
9 changes: 9 additions & 0 deletions deps/NanoSVG/NanoSVG.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# In PrusaSlicer 2.6.0 we switched from https://github.com/memononen/nanosvg to its fork https://github.com/fltk/nanosvg
# because this last implements the new function nsvgRasterizeXY() which we now use in GLTexture::load_from_svg()
# for rasterizing svg files from their original size to a squared power of two texture on Windows systems using
# AMD Radeon graphics cards

orcaslicer_add_cmake_project(NanoSVG
URL https://github.com/fltk/nanosvg/archive/abcd277ea45e9098bed752cf9c6875b533c0892f.zip
URL_HASH SHA256=e859938fbaee4b351bd8a8b3d3c7a75b40c36885ce00b73faa1ce0b98aa0ad34
)
Ocraftyone marked this conversation as resolved.
Show resolved Hide resolved

Large diffs are not rendered by default.

15 changes: 9 additions & 6 deletions deps/wxWidgets/wxWidgets.cmake
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
set(_wx_git_tag v3.1.5)
set(_wx_git_tag v3.2.1)
set(_wx_patch_name 0001-patch-v3.2.1-for-OrcaSlicer.patch)

set(_wx_toolkit "")
set(_wx_private_font "-DwxUSE_PRIVATE_FONTS=1")
Expand All @@ -17,21 +18,21 @@ else ()
endif ()

if (MSVC)
set(_patch_cmd if not exist WXWIDGETS_PATCHED ( "${GIT_EXECUTABLE}" apply --verbose --ignore-space-change --whitespace=fix ${CMAKE_CURRENT_LIST_DIR}/0001-wxWidget-fix.patch && type nul > WXWIDGETS_PATCHED ) )
set(_patch_cmd if not exist WXWIDGETS_PATCHED ( "${GIT_EXECUTABLE}" apply --verbose --ignore-space-change --whitespace=fix ${CMAKE_CURRENT_LIST_DIR}/${_wx_patch_name} && type nul > WXWIDGETS_PATCHED ) )
else ()
set(_patch_cmd test -f WXWIDGETS_PATCHED || ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/0001-wxWidget-fix.patch && touch WXWIDGETS_PATCHED)
set(_patch_cmd test -f WXWIDGETS_PATCHED || ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/${_wx_patch_name} && touch WXWIDGETS_PATCHED)
endif ()

if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
set(_patch_cmd ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/0001-wxWidget-fix.patch)
set(_patch_cmd ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/${_wx_patch_name})
endif ()

orcaslicer_add_cmake_project(
wxWidgets
GIT_REPOSITORY "https://github.com/wxWidgets/wxWidgets"
GIT_TAG ${_wx_git_tag}
PATCH_COMMAND ${_patch_cmd}
DEPENDS ${PNG_PKG} ${ZLIB_PKG} ${EXPAT_PKG} dep_TIFF dep_JPEG
DEPENDS ${PNG_PKG} ${ZLIB_PKG} ${EXPAT_PKG} dep_TIFF dep_JPEG dep_NanoSVG
CMAKE_ARGS
-DwxBUILD_PRECOMP=ON
${_wx_toolkit}
Expand All @@ -47,7 +48,9 @@ orcaslicer_add_cmake_project(
-DwxUSE_WEBVIEW=ON
${_wx_edge}
-DwxUSE_WEBVIEW_IE=OFF
-DwxUSE_REGEX=builtin
-DwxUSE_NANOSVG=sys
-DwxUSE_NANOSVG_EXTERNAL=ON
-DwxUSE_REGEX=OFF
-DwxUSE_LIBXPM=builtin
-DwxUSE_LIBSDL=OFF
-DwxUSE_XTEST=OFF
Expand Down
5 changes: 4 additions & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ if (SLIC3R_GUI)
# wrong libs for opengl in the link line and it does not link to it by himself.
# libslic3r_gui will link to opengl anyway, so lets override wx
list(FILTER wxWidgets_LIBRARIES EXCLUDE REGEX OpenGL)


if (UNIX AND NOT APPLE)
list(APPEND wxWidgets_LIBRARIES X11 wayland-client wayland-egl EGL)
endif ()
# list(REMOVE_ITEM wxWidgets_LIBRARIES oleacc)
message(STATUS "wx libs: ${wxWidgets_LIBRARIES}")

Expand Down
1 change: 0 additions & 1 deletion src/OrcaSlicer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4744,7 +4744,6 @@ int CLI::run(int argc, char **argv)
}
}

ThumbnailsParams thumbnail_params;
GLShaderProgram* shader = opengl_mgr.get_shader("thumbnail");
if (!shader) {
BOOST_LOG_TRIVIAL(error) << boost::format("can not get shader for rendering thumbnail");
Expand Down
1 change: 0 additions & 1 deletion src/nanosvg/README.txt

This file was deleted.

Loading