Update wxWidgets to v3.2.1 #2905

Ocraftyone · 2023-11-27T12:35:58Z

-Updates wxWidgets from v3.1.5 to v3.2.1
-Add NanoSVG as a CMake dependency and remove from src (NanoSVG is now used by wxWidgets too)
-Implement wxBitmapBundle in many of the common components and BitmapCache

Misc Updates:
-WipeTowerDialog refactored to remove simple/advanced code as this functionality was disabled by BBL
-Fix blank plate being added to the object list
-On editing the fila. column in the objects list or object table, show drop down when ComboBox is shown. Editing is also completed when the drop down is closed.

Breaking Changes:
-ScalableBitmap[wxExtensions]: GetBmpSize, GetBmpHeight, and GetBmpWidth have been renamed to GetSize, GetHeight, and GetWidth respectivly.
-wxExtensions: msw_rescale_menu() has been renamed to sys_color_changed_menu()
-ScalableBitmap, LockButton, ScalableButton, ModeSizer [wxExtensions]: msw_rescale() has been renamed to sys_color_changed()

Based on prusa3d/PrusaSlicer@9a7e024 Co-authored-by: tamasmeszaros <[email protected]>

Everything seems to be working (including the plater). I am not seeing any graphical issues

Removed simple version of the dialog since BBS removed the functionality but left the code. Center the table (only seen when the table is smaller than the minimum size of the dialog) Fix issue where editing a value causes the m_min_flush_label to change colors slightly Fix an issue where changing a value or running an auto calc changes the disabled value from "-" to "0"

Update NanoSVG to work with PR SoftFever#2780

# Conflicts: # src/nanosvg/README.txt # src/nanosvg/nanosvg.h # src/nanosvg/nanosvgrast.h # src/slic3r/GUI/BitmapCache.cpp # src/slic3r/GUI/BitmapCache.hpp # src/slic3r/GUI/ImGuiWrapper.cpp

leaving colPrint and colEditing cases alone as it does not seem to impact anything

-Rename msw_rescale to sys_color_changed -Replace GetBmpSize, GetBmpWidth, GetBmpHeight with renamed version (same name without "Bmp") Both of these changes were also made by PrusaSlicer. Original Commit: prusa3d/PrusaSlicer@066b567 Co-authored-by: YuSanka <[email protected]>

disable finding bundle in the cache to match load_svg update to match values used in load_svg

…pdate-wxwidgets

SoftFever · 2023-12-04T15:20:10Z

Looks good now.

Also, I must thank you again for helping revamp the CI/CD previously, so I don't have to prepare the prebuilt dependencies anymore. :)
Much appreciated! !

SoftFever

Looks good

Ocraftyone · 2023-12-04T15:21:22Z

@SoftFever Everything looks good on my end then. Windows looks great.
I think linux is fine some of the buttons along the top look a bit thin and I am getting a graphical issue with a lock showing up instead of the new BBL circular arrow next to the profile select (though i am getting this with the nightly too 🤷). I don't know how much of an issue these are because I can only check via emulator

Ocraftyone · 2023-12-04T15:22:05Z

Looks good now.

Also, I must thank you again for helping revamp the CI/CD previously, so I don't have to prepare the prebuilt dependencies anymore. :) Much appreciated! !

No problem! Had lots of fun troubleshooting that 😄

SoftFever · 2023-12-04T15:25:45Z

@SoftFever Everything looks good on my end then. Windows looks great. I think linux is fine some of the buttons along the top look a bit thin and I am getting a graphical issue with a lock showing up instead of the new BBL circular arrow next to the profile select (though i am getting this with the nightly too 🤷). I don't know how much of an issue these are because I can only check via emulator

with so many changes integrated(don't forget @Noisyfox 's pending large PR), there will be a lot "fun" to catch bugs, LOL

zviratko · 2023-12-04T19:28:49Z

FYI I am having serious performance problems with high-poly models most likely related to this commit.
macOS Arm64 (M1 Max)
Try importing something like this: https://www.printables.com/model/331094-articulated-christmas-dragon

Ocraftyone · 2023-12-04T23:49:20Z

Hmm. I am not aware of anything in this commit that should affect the performance of rendering models. This does not touch any of the opengl rendering. Are you able to try the nightly before this commit and see if the issue persists?

Edit: this should be a link to the build artifacts for that commit

Ocraftyone · 2023-12-05T00:00:22Z

I don't have access to Mac at all. Maybe @igiannakas can help?

Noisyfox · 2023-12-05T03:19:26Z

Having trouble on windows with display scaling set to 200%

Left: 1.8.1, right: current master build 25a0554

Noisyfox · 2023-12-05T03:50:44Z

I think the problem is wxBitmap is still used in places like BBLToolbar, which should be replaced with wxBitmapBundle

igiannakas · 2023-12-05T05:56:46Z

I don't have access to Mac at all. Maybe @igiannakas can help?

I’ll check it out whether there is a difference between the builds performance wise - give me a few hours and I’ll come back to you

Noisyfox · 2023-12-05T06:45:54Z

I can now confirm that (at least) part of the issue was caused by not using the bitmapbundle, as some of the issues are gone after Noisyfox@cb60705 :

Noisyfox · 2023-12-05T06:54:40Z

I've raised #3000 for tracking and fixing Windows scaling related issues.

superfloh247 · 2023-12-05T07:28:47Z

Sidenote: I usually update my sources just with git pull and then build_release_macos.sh.

This fails in this case, because the patch applied to the wxwidget dep creates a merge conflict which build_release_macos.sh does not detect.

I had to manually remove the dep rm -rf deps/build_arm64/dep_wxWidgets-prefix and now the build succeeds again.

igiannakas · 2023-12-05T09:07:50Z

Hmm. I am not aware of anything in this commit that should affect the performance of rendering models. This does not touch any of the opengl rendering. Are you able to try the nightly before this commit and see if the issue persists?

Edit: this should be a link to the build artifacts for that commit

Hey

#2934

This one is causing the performance problem. I tried a build with the change reverted and the model is properly responsive.

@Noisyfox something to look into?

igiannakas · 2023-12-05T09:18:50Z

Done a bit more digging on the perf issues. 1.8.1 runs smooth as butter on the 3d Preview -> 1.9 dev without the above change #2934 runs slower but workable. So there is something more that has changed there impacting performance. Then #2934 cause it to be completely unworkable for large models.

zviratko · 2023-12-05T09:37:42Z

~~#2934 is not it. I had a build without it and it had huge problems as well.~~ I was wrong, it seems to be it.

I will try narrowing it down, but for some reason most of the builds don't actually run for me (it says the app is damaged), so I can't test every commit.

The first one works fine
The second one runs like crap
I'll try testing ones between....

igiannakas · 2023-12-05T09:39:03Z

#2934 is not it. I had a build without it and it had huge problems as well. I will try narrowing it down, but for some reason most of the builds don't actually run for me (it says the app is damaged), so I can't test every commit.

The first one works fine The second one runs like crap I'll try testing ones between....

it is - there is a massive slow down because of this at least on my machine. There is a further PR that hits performance (which is what you're seeing probably) - I'll try and identify.

igiannakas · 2023-12-05T09:42:09Z

I've opened a bug here so we can track it in the right place: #3002

zviratko · 2023-12-05T09:43:12Z

It's possible. I have 3 OrcaSlicer versions, the last one has outlines and I can't tell a difference from the already slow one :) (it looks great, though!)

Ocraftyone · 2023-12-06T06:48:12Z

@igiannakas Thank you!

Ocraftyone · 2023-12-06T06:50:48Z

@superfloh247 Yes, this is how it has been for a while. I am unsure of a quick and easy way to determine if deps have been updated via shell script, but I would assume there is a way for this to be done (I know GH actions uses a hash of the deps dir). I would suggest creating an enhancement ticket.

igiannakas · 2023-12-07T07:51:33Z

Found crashing bug - exec bad access when clicking on the filament selector in the objects tab.

Ocraftyone and others added 30 commits November 5, 2023 03:45

Upgrade wxWidgets to 3.2.1

2302245

Based on prusa3d/PrusaSlicer@9a7e024 Co-authored-by: tamasmeszaros <[email protected]>

Merge branch 'main' into enh-update-wxwidgets

961629b

Implement BitmapCache

a977c69

update wxExtensions while keeping legacy items

e114881

update dc.DrawBitmap calls to use get_bitmap

cdff9ba

Fix GetSize/Width/Height calls

77a143a

update BitmapComboBox

eba3fe2

fix ifndef in wxExtensions.hpp

d4676ee

update my todos to OcraftyoneTODO

dc062f1

Get to a compilable state

03754b5

Everything seems to be working (including the plater). I am not seeing any graphical issues

fix extruder color icons

7acae72

fix crash on opening support tab

92c9a53

remove GetBmpSize method from DropDown.cpp

7cfa854

Update TextInput to use bitmap bundles

510a4a0

update a TODO after testing

6d149e0

fix the rendering of the icons on combobox

413e875

fix a few todos

506e1f4

fix WipeTowerDialog.cpp

c9284cc

Merge branch 'main' into enh-update-wxwidgets

62d689b

update a few todos

cbbeb55

Update some todos

3f0083c

Show dropdown when editing is started

6e7dfc5

Update NanoSVG.cmake

7b1f49f

Update NanoSVG to work with PR SoftFever#2780

Merge branch 'main' into enh-update-wxwidgets

53bc949

# Conflicts: # src/nanosvg/README.txt # src/nanosvg/nanosvg.h # src/nanosvg/nanosvgrast.h # src/slic3r/GUI/BitmapCache.cpp # src/slic3r/GUI/BitmapCache.hpp # src/slic3r/GUI/ImGuiWrapper.cpp

Dim the icon on ComboBox when disabled

bc21ab6

solve ObjectDataViewModel todos

5162232

leaving colPrint and colEditing cases alone as it does not seem to impact anything

Merge branch 'main' into enh-update-wxwidgets

3b5c571

update BitmapCache::from_svg

3a3301b

disable finding bundle in the cache to match load_svg update to match values used in load_svg

Ocraftyone added 2 commits December 4, 2023 09:46

revert outside plate changes

fd436ea

Merge remote-tracking branch 'origin/enh-update-wxwidgets' into enh-u…

737427d

…pdate-wxwidgets

SoftFever approved these changes Dec 4, 2023

View reviewed changes

SoftFever merged commit 25a0554 into SoftFever:main Dec 4, 2023
12 checks passed

Ocraftyone deleted the enh-update-wxwidgets branch December 4, 2023 15:23

Noisyfox linked an issue Dec 5, 2023 that may be closed by this pull request

Windows: Black preview in send print dialog #2925

Closed

2 tasks

igiannakas mentioned this pull request Dec 5, 2023

Add a simple subtle outline effect by drawing back faces using wireframe mode #2934

Merged

Noisyfox mentioned this pull request Dec 20, 2023

1.9-Dev: Crash when selecting filament #3202

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update wxWidgets to v3.2.1 #2905

Update wxWidgets to v3.2.1 #2905

Ocraftyone commented Nov 27, 2023

SoftFever commented Dec 4, 2023 •

edited

Loading

SoftFever left a comment

Ocraftyone commented Dec 4, 2023

Ocraftyone commented Dec 4, 2023

SoftFever commented Dec 4, 2023

zviratko commented Dec 4, 2023

Ocraftyone commented Dec 4, 2023 •

edited

Loading

Ocraftyone commented Dec 5, 2023

Noisyfox commented Dec 5, 2023 •

edited

Loading

Noisyfox commented Dec 5, 2023

igiannakas commented Dec 5, 2023

Noisyfox commented Dec 5, 2023 •

edited

Loading

Noisyfox commented Dec 5, 2023

superfloh247 commented Dec 5, 2023

igiannakas commented Dec 5, 2023

igiannakas commented Dec 5, 2023

zviratko commented Dec 5, 2023 •

edited

Loading

igiannakas commented Dec 5, 2023

igiannakas commented Dec 5, 2023

zviratko commented Dec 5, 2023

Ocraftyone commented Dec 6, 2023

Ocraftyone commented Dec 6, 2023

igiannakas commented Dec 7, 2023

Update wxWidgets to v3.2.1 #2905

Update wxWidgets to v3.2.1 #2905

Conversation

Ocraftyone commented Nov 27, 2023

SoftFever commented Dec 4, 2023 • edited Loading

SoftFever left a comment

Choose a reason for hiding this comment

Ocraftyone commented Dec 4, 2023

Ocraftyone commented Dec 4, 2023

SoftFever commented Dec 4, 2023

zviratko commented Dec 4, 2023

Ocraftyone commented Dec 4, 2023 • edited Loading

Ocraftyone commented Dec 5, 2023

Noisyfox commented Dec 5, 2023 • edited Loading

Noisyfox commented Dec 5, 2023

igiannakas commented Dec 5, 2023

Noisyfox commented Dec 5, 2023 • edited Loading

Noisyfox commented Dec 5, 2023

superfloh247 commented Dec 5, 2023

igiannakas commented Dec 5, 2023

igiannakas commented Dec 5, 2023

zviratko commented Dec 5, 2023 • edited Loading

igiannakas commented Dec 5, 2023

igiannakas commented Dec 5, 2023

zviratko commented Dec 5, 2023

Ocraftyone commented Dec 6, 2023

Ocraftyone commented Dec 6, 2023

igiannakas commented Dec 7, 2023

SoftFever commented Dec 4, 2023 •

edited

Loading

Ocraftyone commented Dec 4, 2023 •

edited

Loading

Noisyfox commented Dec 5, 2023 •

edited

Loading

Noisyfox commented Dec 5, 2023 •

edited

Loading

zviratko commented Dec 5, 2023 •

edited

Loading