Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 94: Added xlsx-renderer-cli #97

Merged
merged 9 commits into from
Dec 6, 2020
Merged

Issue 94: Added xlsx-renderer-cli #97

merged 9 commits into from
Dec 6, 2020

Conversation

Siemienik
Copy link
Owner

@Siemienik Siemienik commented Nov 19, 2020 •
edited
Loading

TODO:

  • readme
  • badges

closes #82 #94

@Siemienik
init project
ba38907
@Siemienik
0.0.1-0
7f0815d
@Siemienik
Command line interface for xlsx-renderer (#1)
3bbac40 
* Add program and command body

* Implement command line interface for xlsx-renderer

* Refactor: move console out of main file,
Update: package.json define sections: bin, types, files
Update: Add documentation
Remove: tests because commanderjs is not test-friendly :( let's investigate it further

* 0.0.1-1

* Update README.md
@Siemienik
Add 'packages/xlsx-renderer-cli/' from commit '3bbac40daa2de526b30192…
fff3d4a 
…d9609d698bfef29918'

git-subtree-dir: packages/xlsx-renderer-cli
git-subtree-mainline: 40123c1
git-subtree-split: 3bbac40
@codecov
Copy link

codecov bot commented Nov 19, 2020 •
edited
Loading

Codecov Report

Merging #97 (42fe4f7) into master (e133913) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines          966       966           
  Branches       134       134           
=========================================
  Hits           966       966
Flag Coverage Δ
xlsx-import 100.00% <ø> (ø)
xlsx-renderer 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e133913...42fe4f7. Read the comment docs.

@Siemienik Siemienik changed the title 82/xlsx renderer cli Issue 82: Added xlsx-renderer-cli Nov 26, 2020
@Siemienik Siemienik marked this pull request as draft November 26, 2020 00:29
@Siemienik Siemienik mentioned this pull request Nov 26, 2020
Open
@Siemienik Siemienik marked this pull request as ready for review November 26, 2020 23:46
@Siemienik
Copy link
Owner Author

@Metastasis could I please you for review?

@Metastasis
Copy link
Contributor

Metastasis commented Nov 27, 2020 •
edited
Loading

@Siemienik ok, I will check it soon

@Siemienik
Copy link
Owner Author

@Metastasis, I did requested fix, could I please you to do review again?

Metastasis
Metastasis approved these changes Dec 6, 2020
View reviewed changes
packages/xlsx-renderer-cli/tslint.json
@@ -0,0 +1,9 @@
{
"extends": [
"tslint:recommended",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tslint going to be deprecated, maybe we should use eslint in new code?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think it may be resolved in #64

@Metastasis
Copy link
Contributor

@Siemienik Yes, thanks, I reviewed changes and I think marked PR as approved

@Siemienik Siemienik mentioned this pull request Dec 6, 2020
Open
5 tasks
@Siemienik
Copy link
Owner Author

@Metastasis Thank you for review :)

@Siemienik Siemienik merged commit ac1e845 into master Dec 6, 2020
@Siemienik Siemienik deleted the 82/xlsx-renderer-cli branch December 6, 2020 21:06
@Siemienik Siemienik mentioned this pull request Dec 6, 2020
Closed
@Siemienik Siemienik changed the title Issue 82: Added xlsx-renderer-cli Issue 94: Added xlsx-renderer-cli Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Metastasis Metastasis Metastasis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Join with xlsx-renderer & xlsx-renderer-cli repositories
2 participants
@Siemienik @Metastasis