Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current lint:fix and format by single lint:fix powered by eslint #64

Open
5 tasks
Siemienik opened this issue Oct 20, 2020 · 1 comment
Open
5 tasks
Labels
accepted It is accepted to do good first issue Good for newcomers

Comments

@Siemienik
Copy link
Owner

Siemienik commented Oct 20, 2020

Actual

Currently keeping code formatted and linted requires to use two commands:

  • yarn lint:fix (or npm run lint:fix)
  • yarn format (or npm run format)

Both of that are proceed by another tool.

Expected

  • yarn lint:fix (or npm run lint:fix) should get same result like current solution.
  • Migrate into eslint

Packages:

This issues should be performed in all packages:

  • xlsx-import
  • xlsx-renderer
  • xlsx-renderer-cli

Further (do not resolve it):

  • add [QA] Auto lint:fix
@Siemienik
Copy link
Owner Author

As @Metastasis point in #97 (comment) , tslint being to be deprecated. I added info into description about migration into eslint

@Siemienik Siemienik changed the title Replace current lint:fix and format by single lint:fix Replace current lint:fix and format by single lint:fix powered by eslint Dec 6, 2020
@Siemienik Siemienik added the good first issue Good for newcomers label Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted It is accepted to do good first issue Good for newcomers
Projects
Status: Accepted
Development

No branches or pull requests

1 participant