Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning meaningful error on missing worksheet #231

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

edmondop
Copy link
Contributor

@edmondop edmondop commented Oct 3, 2023

Addresses #230

Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6be12e3) 100.00% compared to head (569d468) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         1098      1105    +7     
  Branches       134       155   +21     
=========================================
+ Hits          1098      1105    +7     
Flag Coverage Δ
xlsx-import 100.00% <100.00%> (ø)
xlsx-renderer 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/xlsx-import/src/Importer.ts 100.00% <100.00%> (ø)
...sx-import/tests/integration/vertical-lists.test.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Siemienik Siemienik merged commit b3befc9 into Siemienik:master Nov 11, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants