Returning meaningful error on missing worksheet (#231)

* Returning meaningful error on missing worksheet
Siemienik · Nov 11, 2023 · b3befc9 · b3befc9
1 parent 6be12e3
commit b3befc9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/xlsx-import/src/Importer.ts b/packages/xlsx-import/src/Importer.ts
@@ -12,7 +12,9 @@ export class Importer implements IImporter {
         const { worksheet } = config;
         const type = (config.type as ImportType) || IMPORT_TYPE_DEFAULT;
         const ws = this.wb.getWorksheet(worksheet);
-
+        if (!ws) {
+            throw new Error(`Worksheet "${worksheet}" not found in workbook.`);
+        }
         return getStrategyByType(type)(config, ws);
     }
 

diff --git a/packages/xlsx-import/tests/integration/vertical-lists.test.ts b/packages/xlsx-import/tests/integration/vertical-lists.test.ts
@@ -26,6 +26,9 @@ describe('testing vertical list - on file "marsjanie-db"', () => {
             ],
             rowOffset: 1,
         },
+        not_existing_wroksheet: {
+            worksheet: 'dummy'
+        }
     };
 
     it('worksheet "szit1"', async () => {
@@ -180,4 +183,11 @@ describe('testing vertical list - on file "marsjanie-db"', () => {
 
         chai.expect(result).eql(expected);
     });
+
+    it(`should return a meaningful error when the worksheet is not found`, async() => {
+        const factory = new ImporterFactory();
+        const importer = await factory.from('tests/data/marsjanie-db.xlsx');
+        const result = () => importer.getAllItems(configs.not_existing_wroksheet);
+        chai.expect(result).to.throw('Worksheet "dummy" not found in workbook.');
+    });
 });