refactor: migrate wallet wasm into sdk #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexfreska
commented
Feb 29, 2024
alexfreska
commented
- Wallet and transaction signing methods are now part of the sdk.
🦋 Changeset detectedLatest commit: 6d41967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alexfreska and the rest of your teammates on |
Merged
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
39582a5 to
f063e25
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
from
b559cac to
6074498
Compare
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
f063e25 to
b72d59b
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
2 times, most recently
from
e63f884 to
d350da4
Compare
n8maninger
reviewed
Feb 29, 2024
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
b72d59b to
21daad8
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
from
d350da4 to
e94290f
Compare
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
21daad8 to
a62d546
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
5 times, most recently
from
7eb4eda to
530fe5e
Compare
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
a62d546 to
469d339
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
from
530fe5e to
3c04f34
Compare
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
469d339 to
e4d5595
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
3 times, most recently
from
42d3d14 to
4aba9ba
Compare
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
e4d5595 to
551ac0c
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
from
4aba9ba to
10350be
Compare
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
551ac0c to
bd85e5a
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
from
10350be to
f110575
Compare
alexfreska
force-pushed
the
02-28-refactor_sdk_rhp
branch
from
bd85e5a to
8d4eb6a
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
from
f110575 to
f2820fe
Compare
alexfreska
force-pushed
the
02-29-refactor_migrate_wallet_wasm_into_sdk
branch
from
f2820fe to
6d41967
Compare
|
@n8maninger this one should be good to go - it matches the comments from the parent PR regarding moving all methods to |
n8maninger
approved these changes
Mar 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.