Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sdk rhp #519

Merged
merged 1 commit into from
Mar 20, 2024
Merged

refactor: sdk rhp #519

merged 1 commit into from
Mar 20, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Feb 29, 2024

  • Updated sdk to latest core changes, updated structure.
  • Follow up will migrate walletd methods into sdk, use sdk in walletd.

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: 8d4eb6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siafoundation/sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

alexfreska commented Feb 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@alexfreska alexfreska force-pushed the 02-28-refactor_sdk_rhp branch from 09b68ae to 0c529dd Compare February 29, 2024 17:57
@alexfreska alexfreska force-pushed the 02-28-refactor_sdk_rhp branch 6 times, most recently from ea37241 to 39582a5 Compare February 29, 2024 19:40
@alexfreska alexfreska force-pushed the 02-28-refactor_sdk_rhp branch 2 times, most recently from f063e25 to b72d59b Compare February 29, 2024 21:14
sdk/rhp/rhp.go Outdated Show resolved Hide resolved
@n8maninger
Copy link
Member

n8maninger commented Mar 19, 2024

I'm not sure I believe the rhp and wallet functions deserve their own package. It requires creating small utility packages (api, utils, marshal) to share javascript utilities.

If we do split them up into distinct packages, I don't think those packages should be "js-aware" and instead have concrete arguments and return values rather than js.Value and api.Result.

@alexfreska alexfreska force-pushed the 02-28-refactor_sdk_rhp branch from a62d546 to 469d339 Compare March 19, 2024 19:47
@alexfreska alexfreska force-pushed the 02-28-refactor_sdk_rhp branch 2 times, most recently from e4d5595 to 551ac0c Compare March 19, 2024 20:38
@alexfreska
Copy link
Member Author

I'm not sure I believe the rhp and wallet functions deserve their own package. It requires creating small utility packages (api, utils, marshal) to share javascript utilities.

If we do split them up into distinct packages, I don't think those packages should be "js-aware" and instead have concrete arguments and return values rather than js.Value and api.Result.

@n8maninger I moved everything into main 👍🏼

@alexfreska alexfreska force-pushed the 02-28-refactor_sdk_rhp branch from 551ac0c to bd85e5a Compare March 19, 2024 20:51
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after addressing Nate's comments this is good to go

@alexfreska alexfreska force-pushed the 02-28-refactor_sdk_rhp branch from bd85e5a to 8d4eb6a Compare March 20, 2024 12:30
@alexfreska
Copy link
Member Author

I think after addressing Nate's comments this is good to go

👍🏼 gtg

@alexfreska alexfreska merged commit 6c0ee43 into main Mar 20, 2024
1 of 2 checks passed
@alexfreska alexfreska deleted the 02-28-refactor_sdk_rhp branch June 7, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants