-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sdk rhp #519
refactor: sdk rhp #519
Conversation
alexfreska
commented
Feb 29, 2024
•
edited
Loading
edited
- Updated sdk to latest core changes, updated structure.
- Follow up will migrate walletd methods into sdk, use sdk in walletd.
🦋 Changeset detectedLatest commit: 8d4eb6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alexfreska and the rest of your teammates on Graphite |
09b68ae
to
0c529dd
Compare
ea37241
to
39582a5
Compare
f063e25
to
b72d59b
Compare
b72d59b
to
21daad8
Compare
21daad8
to
a62d546
Compare
I'm not sure I believe the If we do split them up into distinct packages, I don't think those packages should be "js-aware" and instead have concrete arguments and return values rather than |
a62d546
to
469d339
Compare
e4d5595
to
551ac0c
Compare
@n8maninger I moved everything into |
551ac0c
to
bd85e5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think after addressing Nate's comments this is good to go
bd85e5a
to
8d4eb6a
Compare
👍🏼 gtg |