Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move downloader to internal package #1715

Merged
merged 1 commit into from
Dec 4, 2024

internal: move downloader

4bda7cd
Select commit
Loading
Failed to load commit list.
Merged

Move downloader to internal package #1715

internal: move downloader
4bda7cd
Select commit
Loading
Failed to load commit list.
Knope Bot / Require changes to be documented required action Dec 4, 2024 in 0s

This pull request has not been documented yet

This project requires changes to be documented via either changesets or conventional commits. Depending on how this pull request is merged, it may not be fully documented:

  • ❌ Squash merging is allowed, but the title is not a conventional commit
  • ❌ Merge commit is allowed and will use PR title, but the title is not a conventional commit
  • ✅ Rebase is allowed, and at least one commit is conventional

You can either correct the above issues, or use a change file to document this pull request. knope-bot can auto-generate a change file based on the pull request title and description. If you are a maintainer, you will see buttons on this screen that correspond to the type of change. Clicking one of these buttons will create the change file detailed below in the .changeset directory of this repository.

Alternatively, you can document the change manually by creating a change file with Knope or following these instructions:

  1. Create a file named .changeset/move_downloader_to_internal_package.md
  2. Copy and paste the below Markdown into the file
  3. Replace "CHANGE_TYPE" with major, minor, or patch (see knope's docs for what those mean)
  4. Edit the content as needed to be applicable to users of the project (not maintainers)

Details

---
default: CHANGE_TYPE
---

# Move downloader to `internal` package

#1715 by @peterjan

This PR moves the `downloader` to our `internal` package, no changes to the code itself. This way it's consistent with the uploader and we're setting ourselves up to move migrations into the `bus` 's autopilot.

Related https://github.com/SiaFoundation/renterd/issues/1646