Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move downloader to internal package #1715

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Move downloader to internal package #1715

merged 1 commit into from
Dec 4, 2024

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Dec 4, 2024

This PR moves the downloader to our internal package, no changes to the code itself. This way it's consistent with the uploader and we're setting ourselves up to move migrations into the bus 's autopilot.

Related #1646

@peterjan peterjan self-assigned this Dec 4, 2024
@peterjan peterjan force-pushed the pj/internal-downloads branch 2 times, most recently from 768f413 to 31e8e60 Compare December 4, 2024 09:26
@peterjan peterjan marked this pull request as ready for review December 4, 2024 09:46
@peterjan
Copy link
Member Author

peterjan commented Dec 4, 2024 •
edited
Loading

Failing on an NDF but since it's moving files around I'm pushing it into review.
edit: obviously investigating the NDF and will fix in separate PR

ChrisSchinnerl
ChrisSchinnerl reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be pretty independent from the RHP4 integration one right? If so I'd merge it first and rebase the other PR

internal/download/downloader/downloader_test.go Outdated Show resolved Hide resolved
internal/download/downloader/downloader_test.go Outdated Show resolved Hide resolved
@peterjan peterjan force-pushed the pj/internal-downloads branch from 31e8e60 to 8f1d168 Compare December 4, 2024 11:39
@peterjan peterjan changed the base branch from pj/rhp4-downloads to its-happening December 4, 2024 11:39
@peterjan peterjan force-pushed the pj/internal-downloads branch from 8f1d168 to c8903d3 Compare December 4, 2024 11:42
@peterjan peterjan force-pushed the pj/internal-downloads branch from c8903d3 to 4bda7cd Compare December 4, 2024 11:51
@peterjan
Copy link
Member Author

peterjan commented Dec 4, 2024

This PR seems to be pretty independent from the RHP4 integration one right? If so I'd merge it first and rebase the other PR

I rebased it. It was independent but it did overlap and it will cause conflicts on pj/rhp4-downloads after being merged. No big deal though.

@ChrisSchinnerl ChrisSchinnerl merged commit f617914 into its-happening Dec 4, 2024
11 of 16 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the pj/internal-downloads branch December 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl Awaiting requested review from ChrisSchinnerl

Assignees

@peterjan peterjan

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjan @ChrisSchinnerl