Avoid excluding transitive dependencies of default dependencies #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
vinistock
force-pushed
the
11-29-avoid_excluding_transitive_dependencies_of_default_dependencies
branch
2 times, most recently
from
2951eae to
1931f0a
Compare
KaanOzkan
approved these changes
Nov 29, 2024
vinistock
force-pushed
the
11-29-avoid_excluding_transitive_dependencies_of_default_dependencies
branch
from
1931f0a to
444c202
Compare
vinistock
deleted the
11-29-avoid_excluding_transitive_dependencies_of_default_dependencies
branch
|
I think this is causing a problem with platform-scoped gems: |
|
Working on a fix. |
vinistock
added a commit
that referenced
this pull request
Jan 6, 2025
### Motivation This PR fixes a mistake made in #2937. We cannot invoke `to_spec` without rescuing `Gem::MissingSpecError` because that gets raised whenever there's a gem that doesn't match platform constraints. ### Implementation Added the missing rescue. ### Automated Tests Added a test that fails before the fix so that we catch this next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that we were incorrectly excluding dependencies if they were transitive to both the
developmentand the default groups. For example:In this case, both
debugandirbdepend onreline. Sinceirbis a part of the default group, we should not excludereline. The bug is that we weren't taking the transitive dependencies of the default group into account and so when we saw thatdebugwas in the development group, we excluded it.Implementation
Started concatenating the transitive dependencies that cannot be excluded into the list.
Automated Tests
Added a test that fails before the fix.