-
Notifications
You must be signed in to change notification settings - Fork 172
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid excluding transitive dependencies of default dependencies (#2937)
### Motivation I noticed that we were incorrectly excluding dependencies if they were transitive to both the `development` and the default groups. For example: ```ruby gem "irb" group :development do gem "debug" end ``` In this case, both `debug` and `irb` depend on `reline`. Since `irb` is a part of the default group, we should not exclude `reline`. The bug is that we weren't taking the transitive dependencies of the default group into account and so when we saw that `debug` was in the development group, we excluded it. ### Implementation Started concatenating the transitive dependencies that cannot be excluded into the list. ### Automated Tests Added a test that fails before the fix.
- Loading branch information
Showing
3 changed files
with
44 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,7 @@ rhtml | |
rindex | ||
rjson | ||
rmtree | ||
rruby | ||
rubyfmt | ||
rubylibdir | ||
rubylibprefix | ||
|