Use Entry#uri where possible instead of file path #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
other
Graphite App
andyw8
approved these changes
Nov 28, 2024
vinistock
changed the base branch from
11-27-store_uris_in_entries_instead_of_file_paths
to
graphite-base/2927
vinistock
force-pushed
the
graphite-base/2927
branch
from
62c7083 to
6172ba4
Compare
vinistock
force-pushed
the
11-27-use_entry_uri_where_possible_instead_of_file_path
branch
from
dca4475 to
1135b23
Compare
vinistock
force-pushed
the
11-27-use_entry_uri_where_possible_instead_of_file_path
branch
from
1135b23 to
8d6bf75
Compare
|
I think they'd be open to it. I had a chance to meet the maintainer at RubyKaigi. There are many things we could upstream there, like all of the foundational parts of writing the language server and dealing with queues, workers, sending requests, expecting responses and so on. We just never had the time because there's always so many other higher priority items. |
Merge activity
|
vinistock
deleted the
11-27-use_entry_uri_where_possible_instead_of_file_path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another step towards #1908
This PR starts using the entry's URI directly instead of rebuilding them from the file paths. This allows us to do less work, but is also an important step so that features will actually work once we index unsaved files.
Implementation
Started using the entry's URI for building responses, like definition locations.