Store URIs in entries instead of file paths #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
This stack of pull requests is managed by Graphite. Learn more about stacking. |
andyw8
approved these changes
Nov 28, 2024
vinistock
deleted the
11-27-store_uris_in_entries_instead_of_file_paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another step towards #1908
Entries need to store URIs instead of file paths. Otherwise, we cannot represent an unsaved file (since there's no file path associated to it, only a URI).
Implementation
This PR changes entries to store URIs, but still maintains the assumption that every entry is backed by a file path on disk. This allows us to minimize the number of changes for this PR.
Once this goes in, then we can start looking into indexing unsaved files, which use the
untitledscheme instead offileand then we will need to handle the possibility of the file path beingnil.