Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout launcher mode to 5% of users #2914

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Rollout launcher mode to 5% of users #2914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,11 +473,6 @@
"type": "boolean",
"default": true
},
"rubyLsp.useLauncher": {
"description": "[EXPERIMENTAL] Uses server launcher for gracefully handling missing dependencies.",
"type": "boolean",
"default": false
},
"rubyLsp.featureFlags": {
"description": "Allows opting in or out of feature flags",
"type": "object",
Expand All @@ -489,6 +484,10 @@
"tapiocaAddon": {
"description": "Opt-in/out of the Tapioca add-on",
"type": "boolean"
},
"launcher": {
"description": "Opt-in/out of the new launcher mode",
"type": "boolean"
}
},
"default": {}
Expand Down
3 changes: 1 addition & 2 deletions vscode/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ function getLspExecutables(
const customBundleGemfile: string = config.get("bundleGemfile")!;
const useBundlerCompose: boolean = config.get("useBundlerCompose")!;
const bypassTypechecker: boolean = config.get("bypassTypechecker")!;
const useLauncher: boolean = config.get("useLauncher")!;

const executableOptions: ExecutableOptions = {
cwd: workspaceFolder.uri.fsPath,
Expand Down Expand Up @@ -112,7 +111,7 @@ function getLspExecutables(
args.push("--branch", branch);
}

if (useLauncher) {
if (featureEnabled("launcher")) {
args.push("--use-launcher");
}

Expand Down
1 change: 1 addition & 0 deletions vscode/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export const SUPPORTED_LANGUAGE_IDS = ["ruby", "erb"];
// Note: names added here should also be added to the `rubyLsp.optedOutFeatureFlags` enum in the `package.json` file
export const FEATURE_FLAGS = {
tapiocaAddon: 0.0,
launcher: 0.05,
};

type FeatureFlagConfigurationKey = keyof typeof FEATURE_FLAGS | "all";
Expand Down