Rollout launcher mode to 5% of users #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
11-26-rollout_launcher_mode_to_5_of_users
branch
from
354ec72 to
537a614
Compare
andyw8
approved these changes
Nov 27, 2024
|
I don't think that supports the feature flags yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been using the new launcher mode for the server for a few weeks now, with zero issues encountered so far.
Let's roll it out to 5% of users. A larger group of users will help surface any other errors in our telemetry.
Implementation
Instead of having a setting dedicated to the launcher, I just made it a feature flag, which is what we should do going forward.