Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enabled_feature? return true when all flags are enabled #2900

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Nov 21, 2024

Motivation

When fixing the mistake on the feature flags object composition, I also noticed that the global state wouldn't return true if the user had their configuration set as

{
  "rubyLsp.featureFlags": {
    "all": true
  }
}

which is not correct. If they enabled all flags, then checking with enabled_feature? should return true.

Implementation

Started returning true if all is enabled.

Automated Tests

Added a test.

Copy link
Member Author

vinistock commented Nov 21, 2024

@vinistock vinistock added bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes labels Nov 21, 2024 — with Graphite App
@vinistock vinistock marked this pull request as ready for review November 21, 2024 21:14
@vinistock vinistock requested a review from a team as a code owner November 21, 2024 21:14
@vinistock vinistock changed the base branch from 11-21-fix_enabled_feature_flags_object_composition to graphite-base/2900 November 21, 2024 21:37
@vinistock vinistock force-pushed the 11-21-make_enabled_feature_return_true_when_all_flags_are_enabled branch from 6178333 to 79d33e5 Compare November 21, 2024 21:37
@vinistock vinistock changed the base branch from graphite-base/2900 to main November 21, 2024 21:37
@vinistock vinistock force-pushed the 11-21-make_enabled_feature_return_true_when_all_flags_are_enabled branch from 79d33e5 to 0d25534 Compare November 21, 2024 21:38
@vinistock vinistock merged commit 03b980b into main Nov 22, 2024
37 checks passed
@vinistock vinistock deleted the 11-21-make_enabled_feature_return_true_when_all_flags_are_enabled branch November 22, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants