Make enabled_feature?
return true when all flags are enabled
#2900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When fixing the mistake on the feature flags object composition, I also noticed that the global state wouldn't return
true
if the user had their configuration set aswhich is not correct. If they enabled all flags, then checking with
enabled_feature?
should returntrue
.Implementation
Started returning
true
ifall
is enabled.Automated Tests
Added a test.