Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enabled feature flags object composition #2899

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix enabled feature flags object composition #2899

merged 1 commit into from
Nov 21, 2024

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Nov 21, 2024 •
edited
Loading

Motivation

I made a mistake when mapping the feature flags into an object. They are supposed to be a hash like object and not an array.

Implementation

Used Object.fromEntries to build the hash.

@vinistock vinistock added the vscode This pull request should be included in the VS Code extension's release notes label Nov 21, 2024 — with Graphite App
@vinistock Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock added the bugfix This PR will fix an existing bug label Nov 21, 2024 — with Graphite App
@vinistock vinistock mentioned this pull request Nov 21, 2024
Merged
@vinistock vinistock marked this pull request as ready for review November 21, 2024 21:12
@vinistock vinistock requested a review from a team as a code owner November 21, 2024 21:12
@vinistock vinistock merged commit d719b86 into main Nov 21, 2024
42 checks passed
@vinistock Graphite App
Copy link
Member Author

Merge activity

  • Nov 21, 4:37 PM EST: A user merged this pull request with Graphite.

@vinistock vinistock deleted the 11-21-fix_enabled_feature_flags_object_composition branch November 21, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha

@andyw8 andyw8 Awaiting requested review from andyw8

@st0012 st0012 Awaiting requested review from st0012

Assignees
No one assigned
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @KaanOzkan