Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noise from "This file is too long" warning #2651

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Reduce noise from "This file is too long" warning #2651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd07fc7
Print to the output tab instead of showing a dialog
alexcrocha Sep 30, 2024
8da3c96
Only log if the scheme is a file
alexcrocha Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/ruby_lsp/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,14 +320,18 @@ def text_document_did_open(message)
language_id: language_id,
)

if document.past_expensive_limit?
if document.past_expensive_limit? && text_document[:uri].scheme == "file"
log_message = <<~MESSAGE
The file #{text_document[:uri].path} is too long. For performance reasons, semantic highlighting and
diagnostics will be disabled.
MESSAGE

send_message(
Notification.new(
method: "window/showMessage",
params: Interface::ShowMessageParams.new(
method: "window/logMessage",
params: Interface::LogMessageParams.new(
type: Constant::MessageType::WARNING,
message: "This file is too long. For performance reasons, semantic highlighting and " \
"diagnostics will be disabled",
message: log_message,
),
),
)
Expand Down
Loading