Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce noise from "This file is too long" warning #2651

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Reduce noise from "This file is too long" warning #2651

merged 2 commits into from
Oct 2, 2024

Conversation

alexcrocha
Copy link
Contributor

@alexcrocha alexcrocha commented Oct 2, 2024 •
edited
Loading

Motivation

Resolves #2550

Frequent notifications for large files are disruptive. Refactoring the files isn't always feasible, so a better solution is needed to reduce the noise.

Implementation

  • Log Only for File Scheme: Notifications will now only log if the scheme is a file, preventing unnecessary alerts for other URI types.
  • Output Tab Logging: Notifications will be printed to the output tab instead of showing a popup, reducing interruptions.

@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

❌ Deploy Preview for ruby-lsp failed.

Name Link
🔨 Latest commit 103e7a6
🔍 Latest deploy log https://app.netlify.com/sites/ruby-lsp/deploys/66fd7729f151a9000860835f

@alexcrocha alexcrocha force-pushed the ar/file-too-long-warning branch from 103e7a6 to 41c2c71 Compare October 2, 2024 17:34
@alexcrocha alexcrocha changed the title [WIP] Reduce noise from "This file is too long" warning Reduce noise from "This file is too long" warning Oct 2, 2024
andyw8
andyw8 reviewed Oct 2, 2024
View reviewed changes
lib/ruby_lsp/server.rb Outdated Show resolved Hide resolved
@alexcrocha alexcrocha added the enhancement New feature or request label Oct 2, 2024
@alexcrocha alexcrocha force-pushed the ar/file-too-long-warning branch from 41c2c71 to 8da3c96 Compare October 2, 2024 17:54
@alexcrocha alexcrocha added the server This pull request should be included in the server gem's release notes label Oct 2, 2024
@alexcrocha alexcrocha marked this pull request as ready for review October 2, 2024 17:55
@alexcrocha alexcrocha requested a review from a team as a code owner October 2, 2024 17:55
@alexcrocha alexcrocha requested review from st0012 and vinistock October 2, 2024 17:55
@alexcrocha alexcrocha merged commit ae70ebc into main Oct 2, 2024
36 of 37 checks passed
@alexcrocha alexcrocha deleted the ar/file-too-long-warning branch October 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@andyw8 andyw8 andyw8 approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce noise from "This file is too long" warning.
3 participants
@alexcrocha @andyw8 @vinistock