Only require RuboCop diagnostic inside the formatter #2610
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
This was referenced Sep 24, 2024
Closed
andyw8
approved these changes
Sep 24, 2024
|
Let's ship this but I like @Earlopain's suggestion in the other PR of having a CI job that doesn't have RuboCop available. |
|
Fair. We should totally add that, but I do want to cut the release with the fix asap. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2604
The RuboCop diagnostic class should only be required if RuboCop is present. In #2589, I mistakenly moved the require to
internal.rb, but trying to require it when RuboCop is not present fails.Implementation
Moved the require inside the class that needs the diagnostic class. That require will only occur if RuboCop is present.
Manual tests