Move CI command checks into testsuite #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
conditional-rubocop
branch
from
77dff24 to
6fe4574
Compare
andyw8
added
bugfix
Earlopain
force-pushed
the
conditional-rubocop
branch
from
5ca33b5 to
7b70dc9
Compare
|
Thank you for the PR! I put #2610 up to address the issue quickly. However, as pointed out in #2610 (comment), we should have an integration test to ensure this doesn't happen again. |
|
Okay, the fix itself is merged. We'd love to have that integration test shipped. |
The CI commands use the Gemfile of the repo, which contains additional gems like `rubocop` and `syntax_tree`. This hides issues like Shopify#2604. So, create a separate Gemfile containing only ruby-lsp and use that instead
Earlopain
force-pushed
the
conditional-rubocop
branch
from
7b70dc9 to
014944e
Compare
Earlopain
changed the title
|
Alright, rebased and left only the tests in. |
vinistock
approved these changes
Sep 30, 2024
vinistock
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2604
Alternative to #2605
Implementation
Just move all the rubocop-specific requires into their own file and gate it once there.
Automated Tests
This moves the two CI checks into the test suite. They would have caught this error, expect rubocop is available to these. So, create a seperate Gemfile that contains only the gem itself. I still have them only run in CI now, they take a bit of time (though not that much overall)
Manual Tests
I tested that ruby-lsp works with and without rubocop in a users gemfile. Offenses show up as expected.