Add a new command to help users migrate launch.json configurations

vscode/package.json

@@ -153,6 +153,11 @@
         "command": "rubyLsp.collectRubyLspInfo",
         "title": "Collect Ruby LSP information for issue reporting",
         "category": "Ruby LSP"
+      },
+      {
+        "command": "rubyLsp.migrateLaunchConfiguration",
+        "title": "Migrate launch.json configurations from rdbg to ruby_lsp",
+        "category": "Ruby LSP"
       }
     ],
     "configuration": {

vscode/src/common.ts

@@ -29,6 +29,7 @@ export enum Command {
   NewMinitestFile = "rubyLsp.newMinitestFile",
   CollectRubyLspInfo = "rubyLsp.collectRubyLspInfo",
   StartServerInDebugMode = "rubyLsp.startServerInDebugMode",
+  MigrateLaunchConfiguration = "rubyLsp.migrateLaunchConfiguration",
 }
 
 export interface RubyInterface {

vscode/src/debugger.ts

@@ -347,10 +347,12 @@ export class Debugger
   }
 
   private logDebuggerMessage(message: string) {
-    const trimmedMessage = message.trimEnd();
-    if (trimmedMessage.length > 0) {
-      LOG_CHANNEL.info(`[debugger]: ${trimmedMessage}`);
-      this.console.append(trimmedMessage);
-    }
+    // In the Output panel, each log automatically gets a new line
+    // And trailing newlines will create one additional line in the panel, so we trimEnd() here to avoid that
+    LOG_CHANNEL.info(`[debugger]: ${message.trimEnd()}`);
+
+    // In the Debug Console, output doesn't get a new line automatically, so we don't trimEnd() here as well as print
+    // the newlines too
+    this.console.append(message);
   }
 }

vscode/src/rubyLsp.ts

@@ -597,6 +597,68 @@
         },
       ),
     );
+    vscode.commands.registerCommand(
+      Command.MigrateLaunchConfiguration,
+      async () => {
+        const workspace = await this.showWorkspacePick();
+
+        if (!workspace) {
+          return;
+        }
+
+        const launchConfig =
+          (vscode.workspace
+            .getConfiguration("launch")
+            ?.get("configurations") as any[]) || [];
+
+        const updatedLaunchConfig = launchConfig.map((config: any) => {
+          if (config.type === "rdbg") {
+            if (config.request === "launch") {
+              const newConfig = { ...config };
+              newConfig.type = "ruby_lsp";
+
+              if (newConfig.askParameters !== true) {
+                delete newConfig.rdbgPath;
+                delete newConfig.cwd;
+                delete newConfig.useBundler;
+
+                const command = (newConfig.command || "").replace(
+                  "${workspaceRoot}/",
+                  "",
+                );
+                const script = newConfig.script || "";
+                const args = (newConfig.args || []).join(" ");
+                newConfig.program = `${command} ${script} ${args}`.trim();
+
+                delete newConfig.command;
+                delete newConfig.script;
+                delete newConfig.args;
+                delete newConfig.askParameters;
+              }
+
+              return newConfig;
+            } else if (config.request === "attach") {
+              const newConfig = { ...config };
+              newConfig.type = "ruby_lsp";
+              // rdbg's `debugPort` could be socket path, or port number, or host:port
+              // we don't do complex parsing here, just assume it's socket path
+              newConfig.debugSocketPath = config.debugPort;
+
+              return newConfig;
+            }
+          }
+          return config;
+        });
+
+        await vscode.workspace
+          .getConfiguration("launch")
+          .update(
+            "configurations",
+            updatedLaunchConfig,
+            vscode.ConfigurationTarget.Workspace,
+          );
+      },
+    );
   }
 
   // Get the current active workspace based on which file is opened in the editor