-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new command to help users migrate launch.json configurations #2450
Merged
+75
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
added
enhancement
New feature or request
vscode
This pull request should be included in the VS Code extension's release notes
labels
Aug 15, 2024
st0012
force-pushed
the
command-to-migrate-launch-json
branch
from
December 5, 2024 20:56
7b8ff80
to
f8fd63c
Compare
dirceu
approved these changes
Dec 18, 2024
andyw8
approved these changes
Dec 18, 2024
}, | ||
{ | ||
"command": "rubyLsp.migrateLaunchConfiguration", | ||
"title": "Migrate launch.json configurations from rdbg to ruby_lsp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"title": "Migrate launch.json configurations from rdbg to ruby_lsp", | |
"title": "Migrate debug launch.json configurations from rdbg to ruby_lsp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to add debug
before it as there's no other types of launch.json
.
Ruby LSP now provides better logging and error messages when the debugger failed to start. And we plan to keep improving the debugging experience in the future. If users are currently using vscode-rdbg and want to try Ruby LSP, we can help them migrate their launch.json configurations to the format used by Ruby LSP.
st0012
force-pushed
the
command-to-migrate-launch-json
branch
from
December 18, 2024 21:34
93e785c
to
a407d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
vscode
This pull request should be included in the VS Code extension's release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ruby LSP now provides better logging and error messages when the debugger failed to start. And we plan to keep improving the debugging experience in the future.
If users are currently using vscode-rdbg and want to try Ruby LSP, we can help them migrate their launch.json configurations to the format used by Ruby LSP.
Implementation
migrateLaunchConfiguration
commandThe 2nd commit is to fix the message formatting issue caused by #2957
Example Result
This is from a real-world Rails project:
And every action works after the migration.
Automated Tests
No test
Manual Tests
rdbg
in itslaunch.json
Migrate launch.json configurations from rdbg to ruby_lsp
command through VS Code's command palette